From owner-freebsd-current@freebsd.org Mon Apr 18 15:10:12 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF19FB13589 for ; Mon, 18 Apr 2016 15:10:12 +0000 (UTC) (envelope-from howard0su@gmail.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8CFF91836 for ; Mon, 18 Apr 2016 15:10:12 +0000 (UTC) (envelope-from howard0su@gmail.com) Received: by mail-io0-x22f.google.com with SMTP id o126so197557312iod.0 for ; Mon, 18 Apr 2016 08:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to; bh=6hOLfLX2nCBu5gsZG26fpcLS1mhf5oR8zcVarlDzfzE=; b=gvOZ3vnKK6tBGv5wlIJ6jaXaRuJQzda1q4H57B5dvRcC3UP+ZyofESPBoRS3EnnRkk 0gbee1u1GUs0i7Mi1K14Q7M7QbXn0CQoRoJa8RI5w0TVy2xKEmj9tpxny0sEENdgEXHF F2U7sOgxP++uz5GfOyO3ytu6cCD8PvYpDnn4ST4OF8UmrUijtI+DBLJ4MHmU/lUYbDAh TJYvRuN1OqH4Vn5EC49xTdFN4ENxL+pjj1UlFa9UY4tyNencTYmpzyX0wlo+bTSACn3G plhYNmfiaQybp2nisVUA+sDB+O/A44y76Bt4ZboKx5b+brQmehhXL2sFQOfTiZe2nd7l 6k/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=6hOLfLX2nCBu5gsZG26fpcLS1mhf5oR8zcVarlDzfzE=; b=dDBW05CHVfD3RpZKEQdgsLjgSI5C9wlQW2n4kHyNPHrGFZZ7MgglC89zeFFelSYbOd UFFFoX2QdNeA9dldc4VUtG/N7Kjdfd2D/NTOFNVEa1JdWHIfV7YqEo8lV1nCrYwyP7if RPyGES+e8h6I1YNHPPY71FIKE77DGteu9o80arONMzyq5wjS7QxwTDEqV99py2HyP7ba MQ1ksKdobO4I3nzxw6Jzb3t4aSZa5ml9PG6a9txrTz0rwt546Sl1xNTPMUXr5tD4K2TH h22HXY/f1lUm3StfITbRyKbOk4HTlKHaSUES9bXMUxUR0DdplVWRan7VGHkHTmQCkm2e YxlQ== X-Gm-Message-State: AOPr4FVJKekMORWH1byxYumypOqJeWTrDHuMOQBYMw8TJ040xO7XjeAQzKptZxDvkp/+7LlzqbXTij2MtUOSQA== MIME-Version: 1.0 X-Received: by 10.107.7.23 with SMTP id 23mr34833204ioh.64.1460992212076; Mon, 18 Apr 2016 08:10:12 -0700 (PDT) Received: by 10.50.128.133 with HTTP; Mon, 18 Apr 2016 08:10:12 -0700 (PDT) Date: Mon, 18 Apr 2016 23:10:12 +0800 Message-ID: Subject: Mis-use of BUS_PASS_ORDER_MIDDLE From: Howard Su To: freebsd-current@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 15:10:12 -0000 I noticed several places there are code like this, especially in some arm low level drivers. EARLY_DRIVER_MODULE(aw_ccu, simplebus, aw_ccu_driver, aw_ccu_devclass, 0, 0, BUS_PASS_BUS + BUS_PASS_ORDER_MIDDLE); =E2=80=8BI feel the usage of BUS_PASS_ORDER_MIDDLE is misused. There are an= other macro EARLY_DRIVER_MODULE_ORDERED, which take an additional parameter "order". I believe BUS_PASS_ORDER_xxx is used for that parameter. =E2=80=8B --=20 -Howard