Date: Tue, 7 Mar 2017 08:58:02 -0800 From: Conrad Meyer <cem@freebsd.org> To: Hiren Panchasara <hiren@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314813 - head/sys/kern Message-ID: <CAG6CVpXshcUFQ4ZiJ70=jNO4mOpvLTyQ9rcCWVYoPfVD33qZjA@mail.gmail.com> In-Reply-To: <201703070020.v270K2vA039655@repo.freebsd.org> References: <201703070020.v270K2vA039655@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Hiren, On Mon, Mar 6, 2017 at 4:20 PM, Hiren Panchasara <hiren@freebsd.org> wrote: > Author: hiren > Date: Tue Mar 7 00:20:01 2017 > New Revision: 314813 > URL: https://svnweb.freebsd.org/changeset/base/314813 > > ... > @@ -1043,6 +1043,11 @@ sbcut_internal(struct sockbuf *sb, int l > { > struct mbuf *m, *next, *mfree; > > + KASSERT(len > 0, ("%s: len is %d but it is supposed to be +ve", > + __func__, len)); Can you change the spelling from +ve to positive? I guess that might mean wrapping the line, but I find the full word much more clear. (Also, I guess the assert is >= 0 now? So that should read "non-negative" rather than "positive." :-) ) > + KASSERT(len <= sb->sb_ccc, ("%s: len: %d is > ccc: %u", > + __func__, len, sb->sb_ccc)); > + > next = (m = sb->sb_mb) ? m->m_nextpkt : 0; > mfree = NULL; Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXshcUFQ4ZiJ70=jNO4mOpvLTyQ9rcCWVYoPfVD33qZjA>