From owner-svn-src-head@freebsd.org Tue Mar 7 17:06:32 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 528DED02F02; Tue, 7 Mar 2017 17:06:32 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E58D610A6; Tue, 7 Mar 2017 17:06:31 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wm0-f41.google.com with SMTP id n11so95131644wma.1; Tue, 07 Mar 2017 09:06:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=CAX6QFZJRuZXkYu92pO+/vETrCBwxrkN7y2NgxWVt/A=; b=J/5QD7I1Q5ovd5C1RVApezhC/RoROGJaUW4JoMuKF/Ax8snAVdRqQKYYamygL/7k+m nJvJbbJTEz0OohWwNKDkBtGk7u/IzeT+3JgJ1MMLpqld3oYnlfPdKNiqGwHCcvQlalIF nAhQ+liTx1OmJvsKinrjMLr/hWQLKDtlBaDtH8kk5ur5dDRJ4sJDs02rU5aiJYIV5XyM Zq57OoNKkUgK2Ulik6LK+C2JtGUMevSgRMF6Hhpv11uPZ7cQQTRGg+m5cxHJcgsfbvbU h3rJv67uhYysJFaccDppq2g8i/OQNPl8u2Y6Ux5SNTaJIEIdK64lkiXmBdoaP+RqVuX2 fMaQ== X-Gm-Message-State: AMke39nVjn8qdYh9chQVfIhgO2qffewLZZWxlpRTv2HBvkgjnSJRd+rIJyJ08U/CI/p75g== X-Received: by 10.28.46.73 with SMTP id u70mr18780186wmu.54.1488905883479; Tue, 07 Mar 2017 08:58:03 -0800 (PST) Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com. [74.125.82.46]) by smtp.gmail.com with ESMTPSA id v1sm677561wra.65.2017.03.07.08.58.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Mar 2017 08:58:03 -0800 (PST) Received: by mail-wm0-f46.google.com with SMTP id n11so94912232wma.1; Tue, 07 Mar 2017 08:58:03 -0800 (PST) X-Received: by 10.28.179.7 with SMTP id c7mr18837913wmf.128.1488905883235; Tue, 07 Mar 2017 08:58:03 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.80.169.4 with HTTP; Tue, 7 Mar 2017 08:58:02 -0800 (PST) In-Reply-To: <201703070020.v270K2vA039655@repo.freebsd.org> References: <201703070020.v270K2vA039655@repo.freebsd.org> From: Conrad Meyer Date: Tue, 7 Mar 2017 08:58:02 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r314813 - head/sys/kern To: Hiren Panchasara Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 17:06:32 -0000 Hi Hiren, On Mon, Mar 6, 2017 at 4:20 PM, Hiren Panchasara wrote: > Author: hiren > Date: Tue Mar 7 00:20:01 2017 > New Revision: 314813 > URL: https://svnweb.freebsd.org/changeset/base/314813 > > ... > @@ -1043,6 +1043,11 @@ sbcut_internal(struct sockbuf *sb, int l > { > struct mbuf *m, *next, *mfree; > > + KASSERT(len > 0, ("%s: len is %d but it is supposed to be +ve", > + __func__, len)); Can you change the spelling from +ve to positive? I guess that might mean wrapping the line, but I find the full word much more clear. (Also, I guess the assert is >= 0 now? So that should read "non-negative" rather than "positive." :-) ) > + KASSERT(len <= sb->sb_ccc, ("%s: len: %d is > ccc: %u", > + __func__, len, sb->sb_ccc)); > + > next = (m = sb->sb_mb) ? m->m_nextpkt : 0; > mfree = NULL; Best, Conrad