Date: Sun, 22 Oct 2017 09:36:04 -0600 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r324841 - head/sys/boot Message-ID: <CANCZdfpPoF0p2cmKg9%2B0dn4Z448ohcHGHHgYnwsutc0CqoSpKA@mail.gmail.com> In-Reply-To: <201710221532.v9MFWt6B039162@pdx.rh.CN85.dnsmgr.net> References: <201710220352.v9M3q3l9028012@repo.freebsd.org> <201710221532.v9MFWt6B039162@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 22, 2017 at 9:32 AM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: imp > > Date: Sun Oct 22 03:52:03 2017 > > New Revision: 324841 > > URL: https://svnweb.freebsd.org/changeset/base/324841 > > > > Log: > > Use BOOTDIR more consistently in defs.mk rather than repeat sys/boot. > > > > Sponsored By: Netflix > > Shouldn't these be BOOTSRC so BOOTDIR can be /boot as BINDIR is /bin? There's currently no BOOTDIR, so there's no conflict. However, as a design point, that may be desirable. Warner > > Modified: > > head/sys/boot/defs.mk > > > > Modified: head/sys/boot/defs.mk > > ============================================================ > ================== > > --- head/sys/boot/defs.mk Sun Oct 22 00:10:18 2017 (r324840) > > +++ head/sys/boot/defs.mk Sun Oct 22 03:52:03 2017 (r324841) > > @@ -6,9 +6,9 @@ > > __BOOT_DEFS_MK__=${MFILE} > > > > BOOTDIR= ${SRCTOP}/sys/boot > > -FICLDIR= ${SRCTOP}/sys/boot/ficl > > +FICLDIR= ${BOOTDIR}/ficl > > LDR_MI= ${BOOTDIR}/common > > -SASRC= ${SRCTOP}/sys/boot/libsa > > +SASRC= ${BOOTDIR}/libsa > > SYSDIR= ${SRCTOP}/sys > > > > # NB: The makefiles depend on these being empty when we don't build > forth. > > > > > > -- > Rod Grimes > rgrimes@freebsd.org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpPoF0p2cmKg9%2B0dn4Z448ohcHGHHgYnwsutc0CqoSpKA>