Date: Tue, 16 Jul 2002 09:44:08 -0400 From: "Brian F. Feldman" <green@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org>, Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 14125 for review Message-ID: <200207161344.g6GDi8678281@green.bikeshed.org> In-Reply-To: Your message of "Mon, 15 Jul 2002 12:36:39 EDT." <200207151636.g6FGadD69438@green.bikeshed.org>
next in thread | previous in thread | raw e-mail | index | archive | help
"Brian F. Feldman" <green@FreeBSD.org> wrote:
> Robert Watson <rwatson@FreeBSD.org> wrote:
> > We probably need to sit down with the source, because I think this still
> > isn't right. mac_update_vnode_from_externalized() is intended to take a
> > fully filled out extmac from the extended attribute, and initialize a
> > vnode label from it. You've changed the code flow so that you call it
> > even when extmac doesn't contain any valid data, which is simply
> > incorrect. Probably what we need is a new entry point intended
> > specifically to handle policies that manage the loading of the
> > externalized form themselves. Something on the order of:
> >
> > mac_update_vnode(vp);
>
> I suppose adding that hook probably will be a solution, if not an elegant
> one. I'd rather it just not call it for policies that have no data but a
> reserved data slow.
slot
As in, policies that will not externalize/internalize directly with the MAC
framework support, but rather their own.
--
Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\
<> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \
Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207161344.g6GDi8678281>