Date: Tue, 10 Nov 2015 19:07:26 +0300 From: Andrey Chernov <ache@freebsd.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, tcltk@FreeBSD.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290637 - head/lib/libc/locale Message-ID: <5642163E.1050405@freebsd.org> In-Reply-To: <20151110133615.GL10134@ivaldir.etoilebsd.net> References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org> <20151110133615.GL10134@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 10.11.2015 16:36, Baptiste Daroussin wrote: > On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: >> On 10.11.2015 16:04, Baptiste Daroussin wrote: >>> On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: >>>> On 10.11.2015 11:11, Baptiste Daroussin wrote: >>>>> Author: bapt >>>>> Date: Tue Nov 10 08:11:27 2015 >>>>> New Revision: 290637 >>>>> URL: https://svnweb.freebsd.org/changeset/base/290637 >>>>> >>>>> Log: >>>>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" locales >>>>> as it used to be in previous version of the locales. Returning >>>>> "POSIX" has too many fallouts. >>>> >>>> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to be >>>> different with real US-ASCII. It is what glibc returns for C/POSIX >>>> locale and most ports expected, being linux-oriented. >>>> >>> I thought about it, but in the end it is probably safer for now that = nl_langinfo >>> return US-ASCII as it did in the past, to reduce breakage with FreeBS= D only code >>> that maybe be existing ou there. >> >> All FreeBSD code I know never check locale this way. IMHO probability = of >> potential danger to meet some linux-oriented port with this check is >> much much higher than to meet similar FreeBSD only code in the wild. I= n >> any case, changing collate order from A-Za-z to aA-zZ we do just now >> have much higher probability to break unknown FreeBSD only code, so on= e >> breaking change can go with other one together. >> > That is true, except that the new collation thing is invalidated as soo= n as you > set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a worka= round while > changing the return value of nl_langinfo() is not workaroundable. Well, forget my improper comparison with collate and see this bug in action right now, in our port tcl8.6.4/unix/tclUnixInit.c: See localeTable and comment above it, there is internal "ansi_x3.4-1968" (i.e. POSIX locale), internal "ascii" and even no alias for our "us-ascii" at all. It gets info through nl_langinfo(CODESET), lowercased. I.e. not using "ANSI_X3.4-1968" breaks all tcl ports right now, this is more essential than hypothetical private FreeBSD only code no one see. --=20 http://ache.vniz.net/ --7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJWQhY+AAoJEKUckv0MjfbKqXUH/0uiAxp2+xqp1Z1B8p5JlqBT YRHkQyGWiJRYaw+HceXwhfGFe3LhIpPAgLaND0H7AIPOFjKP5B9kDr4OKwY6CjFI 2ogBIlkJkLJvSshS2DzSICiGrsAbs2hAGx7FHIODtaSEx6jSrlbDX8a/sBETopeT uT0Z95hnBWfut5eEQuymQnrAS0rCr2IcJECuzFInZ57KJ0RmruLdSZtNO/VSCIEU 99YDp5MAMk9/YdQvS9nAWF/mlu/nQSEN0dHSXWt0q507OovOkFtPvihIYUCMFZxe BkbNwYXCSMJ5q4W9FvklGHXz6qJkkOKiwh0EQYklXeMaEBfdbRPItKL/SchFyYg= =mbgi -----END PGP SIGNATURE----- --7eBmxXoclN9i9Gr1lbf6o14rJp3IvHNmN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5642163E.1050405>