From owner-freebsd-current@FreeBSD.ORG  Fri Oct 14 16:37:44 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 835AD16A41F
	for <freebsd-current@freebsd.org>; Fri, 14 Oct 2005 16:37:44 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2B4FB43D46
	for <freebsd-current@freebsd.org>; Fri, 14 Oct 2005 16:37:43 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id 7B159BC66;
	Fri, 14 Oct 2005 16:37:42 +0000 (UTC)
To: Eric Anderson <anderson@centtech.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 14 Oct 2005 11:23:12 CDT."
	<434FDB70.5040701@centtech.com> 
Date: Fri, 14 Oct 2005 18:37:42 +0200
Message-ID: <32027.1129307862@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: ufsstat - testers / feedback wanted! 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Oct 2005 16:37:44 -0000

In message <434FDB70.5040701@centtech.com>, Eric Anderson writes:
>Poul-Henning Kamp wrote:

>>>From what it sounds like, you'd also like to see per-mount point stats, 
>>>but from the vfs layer, right?   If that's true, then do you have any 
>>>suggestions on how to store the statistics for each mounted fs?
>> 
>> 
>> In struct mount ?
>
>Ok - so I'd place my struct vfsstats in the mount struct, so each fs 
>records it's own stats if the mount option is enabled.  (reiterating to 
>make sure I'm understanding correctly)

Or, depending if this is easier, have the VOP_FOO() functions increment
the stats if the mountpoint flag is set.

>Also - is it best to increment the counters at the beginning of the 
>operation, end, or something else?

The only difference is that at the end you can also record the
return code and make a counter for "failure" if you want.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.