From owner-freebsd-stable@FreeBSD.ORG  Tue Nov 18 20:00:21 2003
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D8ED016A4CE; Tue, 18 Nov 2003 20:00:21 -0800 (PST)
Received: from ntmk.tagil.ru (ntmk.tagil.ru [195.151.0.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 31ACE43F85; Tue, 18 Nov 2003 20:00:19 -0800 (PST)
	(envelope-from boris@tagnet.ru)
Received: from tagnet.ru (boris.nikom.ru [10.1.16.195])
	by ntmk.tagil.ru (8.9.3/8.9.1) with ESMTP id JAA45164;
	Wed, 19 Nov 2003 09:00:01 +0500 (YEKT)
Message-ID: <3FBAEAC1.7090709@tagnet.ru>
Date: Wed, 19 Nov 2003 09:00:01 +0500
From: Boris Kovalenko <boris@tagnet.ru>
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: ru, en-us, en
MIME-Version: 1.0
To: brian@Awfulhak.org, freebsd-stable <freebsd-stable@freebsd.org>,
	freebsd-current <freebsd-current@freebsd.org>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Subject: ppp RADIUS accounting bug
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 04:00:22 -0000

Hello!

    I found a serious bug in RADIUS accounting code. The problem is that
OctetsIn and OctetsOut are defined as unsingned long long, but the 
RADIUS supports only INT32 values, so, when
we're doing rad_put_int(r->cx.rad, RAD_ACCT_OUTPUT_OCTETS, 
stats->OctetsOut) in radius.c for OctetsOut (and OctetsIn also) we 
loosing information if OctetsOut is greater then INT32_MAX. This should 
be fixed.

Regards,
    Boris