From owner-freebsd-net@FreeBSD.ORG Wed Jan 21 09:59:01 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5623C10656E5; Wed, 21 Jan 2009 09:59:01 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-ew0-f20.google.com (mail-ew0-f20.google.com [209.85.219.20]) by mx1.freebsd.org (Postfix) with ESMTP id 8703F8FC12; Wed, 21 Jan 2009 09:59:00 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by ewy13 with SMTP id 13so1753662ewy.19 for ; Wed, 21 Jan 2009 01:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=UEPr4nPPnDQ9KfMaGM8aqT9ezcz6yV93M6D18XCYigI=; b=fCVo6hO4wD1BqEJVgAvaXLOVLWUvleGtecLLFGYcOGkZyrGNlvXLj4geGVxS8QPu/3 UsDk4nuy790npMWjEzwkns4wSdNBFBQanAmHMpRaSs8ouPejPpV9Fkoqe3wU0wxCcKF4 Ons/gc5p/kXXlSjV5mNit6trOwlYkgmeIXsrg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=JERruSryZVxac1AQrgRs3auP1PcGmHT10LVmnvAqMuZc8SRpGL1jgPlAWKC3kjLoZ2 fUlhkDE1xLsk/8k1u2o73pNusnJp2ooHwCmxtNgUKKGQRDD/2Ffx6xSmJQ4jTvmLNwBE lJdMRX+bO0IA28E+5xGbE1kJi8A8puxoUHMWg= MIME-Version: 1.0 Received: by 10.210.141.17 with SMTP id o17mr4389333ebd.146.1232531938942; Wed, 21 Jan 2009 01:58:58 -0800 (PST) In-Reply-To: <2a41acea0901080109l6189b379q4a348cc80527e90e@mail.gmail.com> References: <000001c970a8$3fa45240$220f000a@mtl.com> <4964C2E9.1060301@bestunion.it> <000001c970d9$4403e590$220f000a@mtl.com> <4964EC4F.8030507@freebsd.org> <2a41acea0901071359w3f41465ajb8206cdef5b7b680@mail.gmail.com> <49652E25.9030705@freebsd.org> <000601c97169$b85717b0$220f000a@mtl.com> <2a41acea0901080109l6189b379q4a348cc80527e90e@mail.gmail.com> Date: Wed, 21 Jan 2009 10:58:58 +0100 Message-ID: <3a142e750901210158p75ee5606oa83275f343b93b86@mail.gmail.com> From: "Paul B. Mahol" To: Jack Vogel Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Eitan Shefi , Angelo Turetta , Sam Leffler , Yony Yossef , freebsd-net@freebsd.org Subject: Re: VLAN interface management - unloading carrying driver hangs the machine X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2009 09:59:01 -0000 On 1/8/09, Jack Vogel wrote: > Fine with me, go do it and I'll take the driver code out :) > > Jack > > > On Thu, Jan 8, 2009 at 12:18 AM, Yony Yossef > wrote: > >> > Jack Vogel wrote: >> > > >> > > >> > > On Wed, Jan 7, 2009 at 9:54 AM, Sam Leffler > > > > wrote: >> > > >> > > Yony Yossef wrote: >> > > >> > > Yony Yossef wrote: >> > > >> > > >> > > /sbin/ifconfig vlan3653 create >> > > >> > > Problem is when I assign an IP to the vlan >> > interface. >> > > In that case, unloading the driver results >> > in hanging >> > > the host. >> > > Does it sound familiar to anybody? >> > > >> > > >> > > Well, surely I'd expect problems by doing so. >> > > The correct way is to >> > > >> > > /sbin/ifconfig vlan3653 destroy >> > > >> > > before unloading the driver. >> > > >> > > Angelo. >> > > >> > > >> > > >> > > Thanks, I didn't know freebsd does not allow it. >> > > >> > > >> > > >> > > This seems wrong. Someone should disallow the driver >> > > detach/unload. Please file a PR about this so the issue >> > is not lost. >> > > >> > > Sam >> > > >> > > >> > > In many drivers, ahem, like mine, there is a test at detach and it >> > > will not allow it if there is a non-NULL trunk. >> > > >> > > Sounds like a broken driver needs to be fixed is all... >> > > >> > I don't agree; drivers should not be required to deal with >> > this. If someone files a PR and assigns it to me I'll look at it. >> > >> > Sam >> > >> >> I agree with Sam. There's no reason to leave this check to the driver. >> >> Yony >> >> > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > What's the state of this issue? It is fixed or not? -- Paul