Date: Thu, 30 Jan 2003 15:20:03 -0800 (PST) From: Andrew Stuart <elitetek@tekrealm.net> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/47622: New Port: misc/gkrellshoot2 Message-ID: <200301302320.h0UNK3Hi002319@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/47622; it has been noted by GNATS.
From: Andrew Stuart <elitetek@tekrealm.net>
To: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47622: New Port: misc/gkrellshoot2
Date: Thu, 30 Jan 2003 15:14:17 -0800
--9jxsPFA5p3P2qPhR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, 29 Jan 2003 at 16:00:15 +0100, Simon 'corecode' Schubert wrote:
> i don't see the purpose here WRT the diff below
what does WRT stand for?
>=20
> > X LIBS =3D $(GTK_LIB)=20
> > X LFLAGS =3D -shared
> > X=20
> > X-CC =3D gcc $(CFLAGS) $(FLAGS)
> > X+CC ?=3D gcc $(CFLAGS)
>=20
> don't seem good. how about this:
>=20
> CC?=3D gcc
> CC+=3D ${CFLAGS}
Interesting, I was told to do it the way above via another commiter, but
I will correct this.
>=20
> > X=20
> > X OBJS =3D gkrellshoot.o
> > X=20
> > X@@ -18,13 +18,7 @@
> > X gkrellshoot.o: gkrellshoot.c
> > X=20
> > X install:
_snip_
> large hunk for a change that could be done in the port's Makefile in a
> much more easy way:
>=20
> do-install:
> @${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.so ${PREFIX}/libexec/gkrellm2/plu=
gins
Again, I was taught to do it this way via the commiter, but defiently
this way looks better and saves me alot of work.
> > X@@ -33,7 +27,6 @@
> > X fi
> > X=20
> > X uninstall:
> > X- rm -f /usr/local/lib/gkrellm2/plugins/gkrellshoot.so
> > X- rm -f /usr/lib/gkrellm2/plugins/gkrellshoot.so
> > X- rm -f $(HOME)/.gkrellm2/plugins/gkrellshoot.so
> > X+ rm -f ${PREFIX}/libexec/gkrellm2/plugins/gkrellshoot.so
>=20
> we don't need that, do we?
Again, was suggested I do this for completeness. Will remove though.
>=20
> > X=20
> > X+all: gkrellshoot.so
>=20
> how about (in port's Makefile):
>=20
> ALL_TARGET=3D ${PORTNAME}.so
>
same as all the above, better way, I will update and submit it again.
=20
> > sed 's/^X//' >gkrellshoot2/Makefile << 'END-of-gkrellshoot2/Makefile'
> > X# New ports collection makefile for: gkrellshoot2
> (-----|1|----)
> > X# Date Created: 28 Jan 2003
> > X# Whom: Andrew Stuart <elitetek@tekrealm.net>
> > X#
> > X# $FreeBSD$
> > X#
> > X
> > XPORTNAME=3D gkrellshoot
> (----|2|----)
>=20
> uhm. why is |1| !=3D |2|?
> there already exists a port 'gkrellshoot'. how about modifying either
> ${PORTNAME} or ${PKGNAMESUFFIX}?
Alas, this is from my own lack of knowledge, but i reference
audio/gkrellmvolume2 and audio/gkrellmms2 which have it set
the same way.
If i change the portname, the port fails to fetch/build, I didnt think
of using pkgnamesuffix as I was trying to follow 'uniform' for the above
mentioned ports.
I appreciate your insite, and I will work on changing these, It's also
helpful, as I was going to add a few other gkrellm 2 plugins.
>=20
> cheers
> simon
>=20
> --=20
> /"\ http://corecode.ath.cx/#donate
> \ /
> \ ASCII Ribbon Campaign
> / \ Against HTML Mail and News
--=20
Andrew Stuart
http://www.tekrealm.net
There are very few personal problems that cannot be solved through a
suitable application of high explosives.
--9jxsPFA5p3P2qPhR
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+ObHJSLAP4zYxy3URAsJcAJ4gLebLAEDa3V8mYZUE99qtGqmVwACdGeb6
MYbwmTHz0mi0xjnWn405RKo=
=A04X
-----END PGP SIGNATURE-----
--9jxsPFA5p3P2qPhR--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301302320.h0UNK3Hi002319>