Date: Thu, 25 Oct 2001 10:47:17 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Bruce Evans <bde@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/conscontrol Makefile Message-ID: <20011025104717.A1211@dragon.nuxi.com> In-Reply-To: <20011025203843.B54744@sunbay.com>; from ru@FreeBSD.org on Thu, Oct 25, 2001 at 08:38:43PM %2B0300 References: <200110251709.f9PH9bD60901@freefall.freebsd.org> <20011025201245.L41293@sunbay.com> <20011025102152.B31465@dragon.nuxi.com> <20011025203843.B54744@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 25, 2001 at 08:38:43PM +0300, Ruslan Ermilov wrote: > > Actually that is not right. "products" come first. This means PROG and > > MAN are above SRCS and CFLAGS. There is CSRG precedence for this (I > > believe I emailed you it in the past). > > > > Please revert this back to rev 1.3. > > > No. Most of the other WARNSified makefiles use that style. *sigh* We've been thru that. Please use usr.sbin/*/Makefile as the style guide right now. Please name which WARNSified Makefiles you are refering to. The ones I've cleaned up their style don't follow what you've done. > PROG= foo > SRCS= foo.c bar.c > CFLAGS+=-DFOO > WARNS?= 2 > MAN= foo.8 > > WARNS relates to CFLAGS. > CFLAGS relates to SRCS. > SRCS defaults to PROG and is optional. All correct, execept you need to add that MAN relates to PROG. That is what puts it right after PROG. > The prototype bsd.prog.mk makefile that doesn't use .if's may look > like this: ..snip.. Nope. Lets take this off this list as your example expands this issue a lot. > > > /me badly needs to find time for Makefile.style(7). > > You, BDE and I do need to finish that off. > Definitely. Until then, please follow usr.sbin/ -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011025104717.A1211>