From owner-p4-projects@FreeBSD.ORG  Fri Dec 15 18:21:35 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6D02416A50B; Fri, 15 Dec 2006 18:21:35 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 28E0B16A505
	for <perforce@freebsd.org>; Fri, 15 Dec 2006 18:21:35 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A3B7B43CA2
	for <perforce@freebsd.org>; Fri, 15 Dec 2006 18:19:43 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id kBFIIfeg074460;
	Fri, 15 Dec 2006 11:18:41 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Fri, 15 Dec 2006 11:19:39 -0700 (MST)
Message-Id: <20061215.111939.1723236289.imp@bsdimp.com>
To: hselasky@c2i.net
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200612150954.58930.hselasky@c2i.net>
References: <200612131032.kBDAWXcE034886@repoman.freebsd.org>
	<20061214.222631.-345496069.imp@bsdimp.com>
	<200612150954.58930.hselasky@c2i.net>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Fri, 15 Dec 2006 11:18:42 -0700 (MST)
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 111622 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Dec 2006 18:21:35 -0000

In message: <200612150954.58930.hselasky@c2i.net>
            Hans Petter Selasky <hselasky@c2i.net> writes:
: On Friday 15 December 2006 06:26, M. Warner Losh wrote:
: > In message: <200612131032.kBDAWXcE034886@repoman.freebsd.org>
: >
: >             Hans Petter Selasky <hselasky@freebsd.org> writes:
: > : http://perforce.freebsd.org/chv.cgi?CH=111622
: > :
: > : Change 111622 by hselasky@hselasky_mini_itx on 2006/12/13 10:31:33
: > :
: > :  Compile fix: Add missing dependency, vnode_if.h.
: > :
: > : Affected files ...
: > :
: > : .. //depot/projects/usb/src/sys/modules/ugen/Makefile#2 edit
: > :
: > : Differences ...
: > :
: > : ==== //depot/projects/usb/src/sys/modules/ugen/Makefile#2 (text+ko) ====
: > :
: > : @@ -3,6 +3,6 @@
: > :  .PATH: ${.CURDIR}/../../dev/usb
: > :
: > :  KMOD= ugen
: > : -SRCS= bus_if.h device_if.h opt_usb.h ugen.c usbdevs.h
: > : +SRCS= bus_if.h device_if.h opt_usb.h ugen.c usbdevs.h vnode_if.h
: >
: > What does the usb driver need vnode_if.h for?  There was an old
: > dependency on it, but it was elimianted.
: >
: 
: I see that <sys/vnode.h> does no longer include "vnode_if.h". I added this 
: bascially to get the code compiling on some older systems, where "vnode_if.h" 
: is still included by <sys/vnode.h>. I will revert this, and keep the 
: "vnode_if.h" patch in my SVN repo only.

sys/vnode.h shouldn't be included by drivers.  That's why we
eliminated this dependency.

Warner