Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Nov 2011 09:31:06 +0400
From:      Ruslan Mahmatkhanov <cvs-src@yandex.ru>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/converters/py-iconvcodec Makefile
Message-ID:  <4EBE049A.5060100@yandex.ru>
In-Reply-To: <20111111204944.GB70958@FreeBSD.org>
References:  <201111112023.pABKNjHp014066@repoman.freebsd.org> <20111111204944.GB70958@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev wrote on 12.11.2011 00:49:
> On Fri, Nov 11, 2011 at 08:23:45PM +0000, Ruslan Mahmatkhanov wrote:
>> rm          2011-11-11 20:23:45 UTC
>>
>>   Modified files:
>>     converters/py-iconvcodec Makefile 
>>   Log:
>>     Deprecate this port. Set for removal on 2011-12-11.
>>   
>>     This module is deprecated since release of Python 2.4
>>     that has `codecs` module in it's standard library. We
>>     have no Python versions less than 2.4 in the tree, no
>>     other ports depend on this one, it's unmaintained and
>>     last release was 8 years ago (Nov 2003).
>>   
>>     PR:            ports/162274
>>     Submitted by:  rm (myself)
>>     Approved by:   novel (mentor)
>>     Feature safe:  yes
> 
> Ruslan,
> 
> Do you mind not prepending leading spaces to your commit log texts?  It is
> not just being inconsistent with what other folks do, but also potentially
> breaks log parsing scripts that expect each line of text to start at ^ w/o
> prefix-chomping it.
> 
> Also, canonical form of single quotes embrace if `foobar', not `foobar`.
> 
> Thank you.
> 
> ./danfe
> 

Sure, thanks for correcting me.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EBE049A.5060100>