From owner-svn-ports-all@freebsd.org Tue Nov 3 14:34:00 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0F85345A645; Tue, 3 Nov 2020 14:34:00 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CQXN738Ckz3yNb; Tue, 3 Nov 2020 14:33:59 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.229.168]) by shaw.ca with ESMTPA id ZxNjkmBc1tdldZxNlkyGau; Tue, 03 Nov 2020 07:33:57 -0700 X-Authority-Analysis: v=2.4 cv=INe8tijG c=1 sm=1 tr=0 ts=5fa16a55 a=7AlCcx2GqMg+lh9P3BclKA==:117 a=7AlCcx2GqMg+lh9P3BclKA==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=nNwsprhYR40A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=lHuvkUVfRjEo1crGzZkA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id 0C4A2206C; Tue, 3 Nov 2020 06:33:54 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 0A3EXrIE098335; Tue, 3 Nov 2020 06:33:53 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202011031433.0A3EXrIE098335@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mateusz Piotrowski <0mp@FreeBSD.org> cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r553975 - head/Mk In-reply-to: <202011031005.0A3A5b5e070662@repo.freebsd.org> References: <202011031005.0A3A5b5e070662@repo.freebsd.org> Comments: In-reply-to Mateusz Piotrowski <0mp@FreeBSD.org> message dated "Tue, 03 Nov 2020 10:05:37 +0000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 03 Nov 2020 06:33:53 -0800 X-CMAE-Envelope: MS4xfP9bqETxKy2N4v2pqOGjVSS8rZmgBmgAu8db6trhaDmrIvkmNGR+INydvsg7FbB9l56wkSHH23PdYXLYtVAn1nUfw79IekiQ43lui2zqiiWX+4KU8+U3 VR0AmlKtvloMA1WyN2vQgauwQM7/dWtkrefyIXO0DW8hT6uZgHRhg1jKzJhzW7/Ptc9064xybwgJD1mV+Gvv1I+cIv6Dyn/+cnA/Z7otbBPxfzgYVQ6rT+55 aVS+QNGwTiEhCR7S6v+iPpW7yTQKSX+9OXwJb7h1bVz8AFZwm6qO5pMA0hakW3VfVApariPwvXasDm2pws6yew== X-Rspamd-Queue-Id: 4CQXN738Ckz3yNb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 14:34:00 -0000 In message <202011031005.0A3A5b5e070662@repo.freebsd.org>, Mateusz Piotrowski w rites: > Author: 0mp > Date: Tue Nov 3 10:05:37 2020 > New Revision: 553975 > URL: https://svnweb.freebsd.org/changeset/ports/553975 > > Log: > Discourage users from using DO_NADA > > It should not be used to make targets do nothing. In such cases, > it's most likely the ports infrastructure which requires fixing. > > Suggested by: bapt > Approved by: portmgr (bapt) > Differential Revision: https://reviews.freebsd.org/D27072 > > Modified: > head/Mk/bsd.port.mk > > Modified: head/Mk/bsd.port.mk > ============================================================================= > = > --- head/Mk/bsd.port.mk Tue Nov 3 09:27:49 2020 (r553974) > +++ head/Mk/bsd.port.mk Tue Nov 3 10:05:37 2020 (r553975) > @@ -2040,6 +2040,10 @@ STAGE_COOKIE?= ${WRKDIR}/.stage_done.${PORTNAM > E}.${PR > > # How to do nothing. Override if you, for some strange reason, would rather > # do something. > +# In general, however, DO_NADA is a relict of the past in the ports Is the word relict probably a typo? Though the words have similar meaning, relic is probably more appropriate. > +# infrastructure, and most of its usage has been removed. If you need to def > ine > +# a target with DO_NADA, then there is a high chance that the ports > +# infrastructure should be fixed instead. > DO_NADA?= ${TRUE} > > # Use this as the first operand to always build dependency. > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.