Date: Fri, 15 Nov 2013 01:03:56 +0400 From: Sergey Kandaurov <pluknet@freebsd.org> To: "George V. Neville-Neil" <gnn@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r258142 - head/sys/net Message-ID: <CAE-mSOKfAgZQMuXJ1mF0vyB6EgRVMQ5CpxNX%2BSh7Q6dHiA=fnQ@mail.gmail.com> In-Reply-To: <201311142007.rAEK7InH068095@svn.freebsd.org> References: <201311142007.rAEK7InH068095@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 November 2013 00:07, George V. Neville-Neil <gnn@freebsd.org> wrote: > Author: gnn > Date: Thu Nov 14 20:07:17 2013 > New Revision: 258142 > URL: http://svnweb.freebsd.org/changeset/base/258142 > > Log: > Shift our OUI correctly. > > Pointed out by: emaste > > Modified: > head/sys/net/ieee_oui.h > > Modified: head/sys/net/ieee_oui.h > ============================================================================== > --- head/sys/net/ieee_oui.h Thu Nov 14 19:53:35 2013 (r258141) > +++ head/sys/net/ieee_oui.h Thu Nov 14 20:07:17 2013 (r258142) > @@ -62,5 +62,5 @@ > */ > > /* Allocate 64K to bhyve */ > -#define OUI_FREEBSD_BHYVE_LOW OUI_FREEBSD + 0x000001 > -#define OUI_FREEBSD_BHYVE_HIGH OUI_FREEBSD + 0x00ffff > +#define OUI_FREEBSD_BHYVE_LOW ((OUI_FREEBSD << 3) + 0x000001) > +#define OUI_FREEBSD_BHYVE_HIGH ((OUI_FREEBSD << 3) + 0x00ffff) Shouldn't it be rather shifted with 24 (3 x 8bits)? -- wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSOKfAgZQMuXJ1mF0vyB6EgRVMQ5CpxNX%2BSh7Q6dHiA=fnQ>