From owner-cvs-all Fri Oct 13 16:17:11 2000 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [207.154.226.10]) by hub.freebsd.org (Postfix) with ESMTP id E03E437B66E; Fri, 13 Oct 2000 16:17:08 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1000) id 7344B2B28E; Fri, 13 Oct 2000 18:17:03 -0500 (CDT) Date: Fri, 13 Oct 2000 16:17:03 -0700 From: Paul Saab To: David Greenman Cc: Paul Saab , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-disk.c src/sys/kern kern_shutdown.c src/sys/sys systm.h Message-ID: <20001013161703.A68869@elvis.mu.org> References: <200010132149.OAA93124@freefall.freebsd.org> <200010132309.QAA11943@implode.root.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <200010132309.QAA11943@implode.root.com>; from dg@root.com on Fri, Oct 13, 2000 at 04:09:57PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG David Greenman (dg@root.com) wrote: > >ps 2000/10/13 14:49:20 PDT > > > > Modified files: > > sys/dev/ata ata-disk.c > > sys/kern kern_shutdown.c > > sys/sys systm.h > > Log: > > Do not allocate a callout for all crashdumps, not just when you panic. > > Did you intend for this to be a double-negative? No.. I noticed I made that mistake after I committed it.. *sigh*. What happened before is if you did a call dumpsys or call boot(0x104) from ddb, the ata driver would allocate a callout for every 4k it wrote and you would eventually run out of callout entries and panic during a dump. -- Paul Saab Technical Yahoo paul@mu.org - ps@yahoo-inc.com - ps@freebsd.org Do You .. uhh .. Yahoo!? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message