Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 14 Jul 2016 00:32:27 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r302792 - head/usr.bin/gcore
Message-ID:  <201607140032.u6E0WRaC030774@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: markj
Date: Thu Jul 14 00:32:27 2016
New Revision: 302792
URL: https://svnweb.freebsd.org/changeset/base/302792

Log:
  Remove gcore's -s option.
  
  It has no effect and is always implicitly set since ptrace(2) stops the
  target process.

Modified:
  head/usr.bin/gcore/extern.h
  head/usr.bin/gcore/gcore.1
  head/usr.bin/gcore/gcore.c

Modified: head/usr.bin/gcore/extern.h
==============================================================================
--- head/usr.bin/gcore/extern.h	Thu Jul 14 00:26:57 2016	(r302791)
+++ head/usr.bin/gcore/extern.h	Thu Jul 14 00:32:27 2016	(r302792)
@@ -31,7 +31,6 @@
  */
 
 #define	PFLAGS_FULL	0x01
-#define	PFLAGS_RESUME	0x02
 
 struct dumpers {
 	int (*ident)(int efd, pid_t pid, char *binfile);

Modified: head/usr.bin/gcore/gcore.1
==============================================================================
--- head/usr.bin/gcore/gcore.1	Thu Jul 14 00:26:57 2016	(r302791)
+++ head/usr.bin/gcore/gcore.1	Thu Jul 14 00:32:27 2016	(r302792)
@@ -28,7 +28,7 @@
 .\"	@(#)gcore.1	8.2 (Berkeley) 4/18/94
 .\" $FreeBSD$
 .\"
-.Dd July 14, 2010
+.Dd July 13, 2016
 .Dt GCORE 1
 .Os
 .Sh NAME
@@ -37,7 +37,6 @@
 .Sh SYNOPSIS
 .Nm
 .Op Fl f
-.Op Fl s
 .Op Fl c Ar core
 .Op Ar executable
 .Ar pid
@@ -66,15 +65,6 @@ behavior.
 As a result, this flag should only be used when the behavior of the
 application and any devices it has mapped is fully understood and any side
 effects can be controlled or tolerated.
-.It Fl s
-Stop the process while gathering the core image, and resume it
-when done.
-This guarantees that the resulting core dump will
-be in a consistent state.
-The process is resumed even if it was
-already stopped.
-The same effect can be achieved manually with
-.Xr kill 1 .
 .El
 .Sh FILES
 .Bl -tag -width /var/log/messages -compact

Modified: head/usr.bin/gcore/gcore.c
==============================================================================
--- head/usr.bin/gcore/gcore.c	Thu Jul 14 00:26:57 2016	(r302791)
+++ head/usr.bin/gcore/gcore.c	Thu Jul 14 00:32:27 2016	(r302792)
@@ -87,7 +87,7 @@ main(int argc, char *argv[])
 
 	pflags = 0;
 	corefile = NULL;
-        while ((ch = getopt(argc, argv, "c:fs")) != -1) {
+        while ((ch = getopt(argc, argv, "c:f")) != -1) {
                 switch (ch) {
                 case 'c':
 			corefile = optarg;
@@ -95,9 +95,6 @@ main(int argc, char *argv[])
 		case 'f':
 			pflags |= PFLAGS_FULL;
 			break;
-		case 's':
-			pflags |= PFLAGS_RESUME;
-			break;
 		default:
 			usage();
 			break;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201607140032.u6E0WRaC030774>