From owner-cvs-all@FreeBSD.ORG  Sat Oct  9 08:25:50 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 07A4116A4CE; Sat,  9 Oct 2004 08:25:50 +0000 (GMT)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9030043D31; Sat,  9 Oct 2004 08:25:49 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.1/8.13.1) with ESMTP id i998PdcG063358;
	Sat, 9 Oct 2004 01:25:43 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200410090825.i998PdcG063358@gw.catspoiler.org>
Date: Sat, 9 Oct 2004 01:25:39 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
To: green@FreeBSD.org
In-Reply-To: <200410090816.i998Gbs5076009@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern subr_witness.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Oct 2004 08:25:50 -0000

On  9 Oct, Brian Feldman wrote:
> green       2004-10-09 08:16:37 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             subr_witness.c 
>   Log:
>   Don't "implicitly order all sleep locks before spin locks" in witness
>   when the spin lock in question isn't -- it's the critical_enter() that
>   KDB set.  No more panic in DDB for console -> syscons -> tty -> knote
>   operations.

If I'm understanding this correctly, calling knote sounds like the wrong
thing to do in this situation ...