Date: Wed, 2 Jun 2021 04:16:29 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Guangyuan Yang <ygy@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f1e718499cb3 - main - www/civetweb: New port: Embedded C/C++ web server Message-ID: <YLcGHWFkYVdIiXIW@FreeBSD.org> In-Reply-To: <202106020218.1522Io42007503@gitrepo.freebsd.org> References: <202106020218.1522Io42007503@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 02, 2021 at 02:18:50AM +0000, Guangyuan Yang wrote: > commit f1e718499cb309115b622453026bbacc4af60d73 > > www/civetweb: New port: Embedded C/C++ web server > > PR: 255974 > Approved by: lwhsu (mentor) Looks like it was not thorougly reviewed prior to approval. > ... > --- /dev/null > +++ b/www/civetweb/Makefile > @@ -0,0 +1,21 @@ > +# Created by: maintainer.freebsd@xpoundit.com > + > +PORTNAME= civetweb > +DISTVERSIONPREFIX= v > +DISTVERSION= 1.14 > +CATEGORIES= www > + > +MAINTAINER= maintainer.freebsd@xpoundit.com > +COMMENT= Embedded C/C++ web server This text makes a nice COMMENT, ... > --- /dev/null > +++ b/www/civetweb/pkg-descr > @@ -0,0 +1,3 @@ > +Embedded C/C++ web server > + > +WWW: https://github.com/civetweb/civetweb ... but very bad port description. It should not be the same as COMMENT verbatim. I should also terminate with a full stop (period). Please (re)read the PHB Section 3.2.1 on how a good pkg-descr file should look like. (Your mentor should have told you this.) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YLcGHWFkYVdIiXIW>