From owner-freebsd-ports@FreeBSD.ORG Sun Aug 24 17:16:45 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B1602C83 for ; Sun, 24 Aug 2014 17:16:45 +0000 (UTC) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id 469D93135 for ; Sun, 24 Aug 2014 17:16:43 +0000 (UTC) Received: (qmail 53439 invoked by uid 89); 24 Aug 2014 17:16:41 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@88.217.180.38) by mail.grem.de with ESMTPA; 24 Aug 2014 17:16:41 -0000 Date: Sun, 24 Aug 2014 19:16:43 +0200 From: Michael Gmelin To: Scot Hetzel Subject: Re: HEADS UP: Berkeley DB 4...4.7 port removals/upgrades may require manual preparation Message-ID: <20140824191643.005f8e1c@bsd64.grem.de> In-Reply-To: References: <53F640EF.7000200@FreeBSD.org> <20140824102826.GB9400@home.opsec.eu> <20140824111149.GD9400@home.opsec.eu> <53F9CEDA.4070309@gmx.de> <20140824142050.5e336477@bsd64.grem.de> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.22; amd64-portbld-freebsd10.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: olli hauer , Kurt Jaeger , ports-list freebsd X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2014 17:16:45 -0000 On Sun, 24 Aug 2014 11:59:37 -0500 Scot Hetzel wrote: > On Sun, Aug 24, 2014 at 7:20 AM, Michael Gmelin > wrote: > > @Olli: Checking Mk/bsd.databasemk it seems like you're right. It's > > quite amusing how this went unnoticed for so long, it has been in > > there for eight years :) > > > > As the original author of the USE_BDB code, the USE_BDB=5 had worked > in the past. As it is supposed to mean that this port only uses that > version of BDB. The code was changed on Aug 21 (r365599) and the > author of the new code might have forgot to test this case. > Not sure if you read the rest of the thread, but this is still working as intended (I tested using both the old and new version). The issue is, that USE_BDB=version means USE_BDB=yes, WITH_BDB_VER=version, but Kurt has WITH_BDB_VER=6 in make.conf, which overrides this version number and version =6 is invalid for devel/ice. So basically it works as designed, Kurt wanted a specific version of bdb, which doesn't work for devel/ice. The fix was to add WANT_BDB_VER= 5 in devel/ice, which I guess is ok, since this is the only version it really works with (and I guess I could remove the INVALID directive now, since WANT means really *want*). My question is, what the point of INVALID_BDB_VER really is in this case, it seems a bit pointless to me given the trouble it caused Kurt and how we resolved this. Having a fully specified list of supported versions in WANT_BDB_VER seems better in this case (assuming WANT supports listing multiple versions). -- Michael Gmelin