Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Aug 2000 13:05:49 -0700
From:      Doug Barton <DougB@gorean.org>
To:        Josef Karthauser <joe@pavilion.net>
Cc:        Warner Losh <imp@village.org>, Ade Lovett <ade@FreeBSD.ORG>, Jonathan Lemon <jlemon@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/games/fortune/datfiles fortunes
Message-ID:  <3996FF9D.C5497459@gorean.org>
References:  <20000807171632.B514@FreeBSD.org> <200008072049.NAA00374@freefall.freebsd.org> <200008072201.QAA34941@harmony.village.org> <20000807171632.B514@FreeBSD.org> <200008072226.QAA35123@harmony.village.org> <20000808145630.L14108@pavilion.net> <399395C7.6CF57646@gorean.org> <20000812180157.C509@pavilion.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Josef Karthauser wrote:
> 
> On Thu, Aug 10, 2000 at 10:57:27PM -0700, Doug Barton wrote:
> > Josef Karthauser wrote:
> >
> > > I'm rewriting the CVSROOT/stuff.pl scripts at the moment.
> > > I'd really appreciate it if any suggestions can include me
> > > in the Cc so that I can build them in.
> >
> >       I'm heartily in favor of adding the cvsweb links. Hoek's procmail recipe
> > has made a world of difference in what I've been able to follow commit
> > wise. Josef, I sent you a patch under seperate cover.
> 
> A problem with this that I can see is what happens when a 'mega' commit
> occurs, i.e. when someone changes lots of files in the same commit.
> It is really necessary to provide cvsweb links for each file/change?

I think the better question is, why is it bad? Sure, it adds some volume to
the mail, but it's not the end of the world. Those mega-commits don't
happen very often, so you're really talking about an edge case. 

> I favour the unique commit id idea instead, and teaching cvsweb or
> something about how to use these to determine a set of related
> commits.  It would then make sense to add a single link to the email
> message that evokes cvsweb to show the commit set.

That seems like a lot of work for very little benefit to me. 

Doug


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3996FF9D.C5497459>