Date: Tue, 11 Jan 2011 16:09:07 -0500 From: "J.R. Oldroyd" <fbsd@opal.com> To: Andrew Gallatin <gallatin@gmail.com> Cc: freebsd-multimedia@freebsd.org, emulation@freebsd.org, freebsd-emulation@freebsd.org, Juergen Lock <nox@jelal.kn-bremen.de>, Alexander Leidinger <Alexander@leidinger.net> Subject: Re: FYI: v4l-linuxulator support in FreeBSD-current now Message-ID: <20110111160907.454c74d7@shibato.opal.com> In-Reply-To: <AANLkTi=Ek4-C5LJtoxo7bTHr8Zn=_QBJfJeXE5Ybk2g-@mail.gmail.com> References: <20091204223126.00005392@unknown> <201001081650.14189.hselasky@c2i.net> <20100108114130.1cfe88c5@shibato.opal.com> <201101110947.46399.hselasky@c2i.net> <20110111092609.7bf82016@shibato.opal.com> <20110111183937.GA36761@triton8.kn-bremen.de> <AANLkTi=Ek4-C5LJtoxo7bTHr8Zn=_QBJfJeXE5Ybk2g-@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/W4R7V1QbhiR=lnfRH/uvidz Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 11 Jan 2011 15:17:59 -0500, Andrew Gallatin <gallatin@gmail.com> wr= ote: > > On Tue, Jan 11, 2011 at 1:39 PM, Juergen Lock <nox@jelal.kn-bremen.de> wr= ote: >=20 > > =C2=A0And FE_[GS]ET_PROPERTY I think are part of the `new' dvb api that > > was introduced when adding support for dvb-s2, which would also > > explain why the naive patch appeared to work: =C2=A0whatever app(s) were > > used to test it probably were just still using the `old' dvb api. > > (Well, or the tests were only done on i386. :) >=20 > Test was done with just azap, dvbtraffic, and test_dvr on amd64.. >=20 > Drew At issue is not if the simple patch works for a few apps. At issue is whether or not FreeBSD should code defensively to protect against possible problems in the future. When I did the V4L shim, my initial test app (Skype) also worked without much of the structure conversion code. I was asked to write additional structure conversion code anyway, because it is the correct way to handle such data when the field sizes are not defined. The good news is that the conversion code is not complex. One copy in function and one copy out function that hande those data types whose length may vary is needed for each such structure. The bad news is, as I understand it, that DVB is tied closely to V4L2, so it may be necessary to implement a complete set of conversion code for all V4L2 functions, too. Is this the case? I'm not sure. On the other hand, if it is working acceptably now, we could just add the simpler patch and punt any conversion code until/if something is found to not work properly, later. -jr --Sig_/W4R7V1QbhiR=lnfRH/uvidz Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEUEARECAAYFAk0sxvMACgkQls33urr0k4lJgQCXTELX/LtEOyoEn15raj0Oc9dw 5gCfSfykYJ0u0MSNq3H0XFxAKTkqxqI= =lEEA -----END PGP SIGNATURE----- --Sig_/W4R7V1QbhiR=lnfRH/uvidz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110111160907.454c74d7>