Date: Wed, 18 Sep 2019 14:53:49 +0100 From: Warner Losh <imp@bsdimp.com> To: Kyle Evans <kevans@freebsd.org> Cc: Garrett Cooper <yaneurabeya@gmail.com>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r352465 - head/share/mk Message-ID: <CANCZdfpqAMLN-%2BCTQz7T0%2BZ%2Bbx__wYaYVUogE2wQ1XaJ=zGBoA@mail.gmail.com> In-Reply-To: <CACNAnaG23b92BjmAMD_Pn1PW4gcYEne6vdaJ9SuOxHU1hbmyvg@mail.gmail.com> References: <201909180158.x8I1wuZu011258@repo.freebsd.org> <0FBC9A62-AE3B-4F27-AABC-06FF45F415F1@gmail.com> <CACNAnaG23b92BjmAMD_Pn1PW4gcYEne6vdaJ9SuOxHU1hbmyvg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 18, 2019, 1:41 PM Kyle Evans <kevans@freebsd.org> wrote: > On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper <yaneurabeya@gmail.com> wrote: > > > > > > > On Sep 17, 2019, at 18:58, Kyle Evans <kevans@freebsd.org> wrote: > > > > > > Author: kevans > > > Date: Wed Sep 18 01:58:56 2019 > > > New Revision: 352465 > > > URL: https://svnweb.freebsd.org/changeset/base/352465 > > > > > > Log: > > > googletest: default-disable on all of MIPS for now > > > > > > Parts of the fusefs tests trigger a bug in current versions of llvm: > IR > > > representation of some routine for the MIPS targets is a function > with a > > > large number of arguments. This then leads the compiler on an hour+ > long > > > goose chase, which is OK if you build the current tree but less-so if > you're > > > trying external toolchain or doing a universe build involving mips > when it > > > eventually gets switched over to LLVM. > > > > > > Better, accurate details can be found in LLVM PR43263. > > > > Uhhhhh... why not do this in tests/sys/... instead? > > Because there's still value in being able to easily enable these for > building/running the complete set of tests through standard build > infrastructure, but it's not worth adding a knob specifically for the > fusefs tests. I also prefer the communication of it being an > off-by-default option and easily deduced from src.conf(5) that this > part of the build is default-disabled on mips/mips. > This is the right way to do this, imho... Warner >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpqAMLN-%2BCTQz7T0%2BZ%2Bbx__wYaYVUogE2wQ1XaJ=zGBoA>