From owner-freebsd-stable@FreeBSD.ORG Tue Oct 2 13:02:26 2007 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F3CF16A418; Tue, 2 Oct 2007 13:02:26 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:610:652::211]) by mx1.freebsd.org (Postfix) with ESMTP id 0FD8713C45D; Tue, 2 Oct 2007 13:02:26 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 6FE6B1CC37; Tue, 2 Oct 2007 15:02:25 +0200 (CEST) Date: Tue, 2 Oct 2007 15:02:25 +0200 From: Ed Schouten To: Vlad GALU Message-ID: <20071002130225.GR12364@hoeg.nl> References: <00ab01c8040c$7c408160$b6db87d4@multiplay.co.uk> <012101c804e5$efa7e9c0$b6db87d4@multiplay.co.uk> <86abr1yb68.fsf@ds4.des.no> <86641pyanc.fsf@ds4.des.no> <86wsu5wuz3.fsf@ds4.des.no> <20071002125702.GQ12364@hoeg.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8CNmCRe8Sh4keFKJ" Content-Disposition: inline In-Reply-To: <20071002125702.GQ12364@hoeg.nl> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , FreeBSD Hackers , Steven Hartland , freebsd-stable@freebsd.org, gepu@flow.rdsnet.ro Subject: Re: How to enable more than 256 pty's? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 13:02:26 -0000 --8CNmCRe8Sh4keFKJ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Ed Schouten wrote: > * Vlad GALU wrote: > > On 10/2/07, Dag-Erling Sm=F8rgrav wrote: > > > "Vlad GALU" writes: > > > > The symptoms were exhibited even with rev. 1.16. I've CC'ed him so > > > > he can catch up with the thread. > > > > > > Which symptoms? I can no longer reproduce the hang-on-close bug. > >=20 > > Strangely enough, me neither. In his case, allocated pts' wouldn't > > get deallocated once the sessions ended. >=20 > This is a known issue IIRC. See line 245 of tty_pts.c 1.16. Can be > easily reproduced by killing the sshd while apps are still running in > the shell. >=20 > I thought we weren't able to destroy the device there, because you can't > destroy a TTY when it is used by an application (i.e. when it's the > controlling terminal). Thought about this 2 seconds after I sent my message: this is also responsible for the `zombie jails': tty's are made with make_dev_cred, which causes ucred's to be leaked, which eventually causes prisons to be leaked. --=20 Ed Schouten WWW: http://g-rave.nl/ --8CNmCRe8Sh4keFKJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFHAkFh52SDGA2eCwURAo5gAJ9hrgjycx8KCSDaMMCAYWO9TAFoaQCggExV nLwhxxIHRHwW/UNjLqqKHKI= =8+HJ -----END PGP SIGNATURE----- --8CNmCRe8Sh4keFKJ--