Date: Sat, 12 Sep 2020 16:35:05 +0000 From: Colin Percival <cperciva@tarsnap.com> To: Alan Somers <asomers@freebsd.org>, Gordon Tetlow <gordon@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-user@freebsd.org Subject: Re: svn commit: r365660 - user/cperciva/freebsd-update-build/patches/12.2-BETA1 Message-ID: <01000174832b94db-36e5b9c0-c71a-4023-b4eb-afa0ea3d1210-000000@email.amazonses.com> In-Reply-To: <CAOtMX2hvn92j%2BD0kVK=WRKipg5Go%2BLvSjZja62J1DU4g%2BeDyHw@mail.gmail.com> References: <202009121518.08CFIqmE024560@repo.freebsd.org> <CAOtMX2hvn92j%2BD0kVK=WRKipg5Go%2BLvSjZja62J1DU4g%2BeDyHw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-09-12 08:31, Alan Somers wrote: > On Sat, Sep 12, 2020 at 9:19 AM Gordon Tetlow <gordon@freebsd.org > <mailto:gordon@freebsd.org>> wrote: > > Author: gordon > Date: Sat Sep 12 15:18:52 2020 > New Revision: 365660 > URL: https://svnweb.freebsd.org/changeset/base/365660 > > Log: > Add needed patch for 12.2-BETA1 to prevent spurious changes through > freebsd-update processing. > > Added: > user/cperciva/freebsd-update-build/patches/12.2-BETA1/ > user/cperciva/freebsd-update-build/patches/12.2-BETA1/0-newvers > > What kinds of spurious changes do you see without this patch? There's three issues: 1. The code which selects which file to install as /etc/pkg/FreeBSD.conf doesn't recognize a fake branch name and installs the "latest" file instead of the "quarterly" file. 2. The branch name gets into /bin/freebsd-version, which is technically correct, but confuses freebsd-update's "don't update files if the only change is the version number" code. 3. The branch name gets into every single .o file in the kernel build, and at this point all hell breaks loose. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?01000174832b94db-36e5b9c0-c71a-4023-b4eb-afa0ea3d1210-000000>