Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Jul 2016 14:58:15 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r303392 - in head: . share/mk
Message-ID:  <201607271458.u6REwF1r059656@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Wed Jul 27 14:58:15 2016
New Revision: 303392
URL: https://svnweb.freebsd.org/changeset/base/303392

Log:
  Remove ${OBJDUMP} as it is not used by the base system
  
  It was added to sys.mk relatively recently (r274503) for EFI builds
  but is no longer used by the base system. The in-tree binutils are
  outdated, will not be updated, and will be removed in the future.
  Remove it from the toolchain build now to slightly simplify the build
  and make sure we don't grow an accidental dependency.
  
  Note that this affects only the toolchain build, and does not affect
  /usr/bin/objdump in the built world.
  
  Reviewed by:	bdrewery
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D6460

Modified:
  head/Makefile.inc1
  head/share/mk/local.meta.sys.mk
  head/share/mk/sys.mk

Modified: head/Makefile.inc1
==============================================================================
--- head/Makefile.inc1	Wed Jul 27 14:27:08 2016	(r303391)
+++ head/Makefile.inc1	Wed Jul 27 14:58:15 2016	(r303392)
@@ -178,7 +178,7 @@ CROSS_BINUTILS_PREFIX=/usr/local/${TARGE
 .endif
 .endif
 .endif
-XBINUTILS=	AS AR LD NM OBJCOPY OBJDUMP RANLIB SIZE STRINGS
+XBINUTILS=	AS AR LD NM OBJCOPY RANLIB SIZE STRINGS
 .for BINUTIL in ${XBINUTILS}
 .if defined(CROSS_BINUTILS_PREFIX) && \
     exists(${CROSS_BINUTILS_PREFIX}${${BINUTIL}})
@@ -539,7 +539,7 @@ HMAKE+=		PATH=${TMPPATH} METALOG=${METAL
 CROSSENV+=	CC="${XCC} ${XCFLAGS}" CXX="${XCXX} ${XCXXFLAGS} ${XCFLAGS}" \
 		CPP="${XCPP} ${XCFLAGS}" \
 		AS="${XAS}" AR="${XAR}" LD="${XLD}" NM=${XNM} \
-		OBJDUMP=${XOBJDUMP} OBJCOPY="${XOBJCOPY}" \
+		OBJCOPY="${XOBJCOPY}" \
 		RANLIB=${XRANLIB} STRINGS=${XSTRINGS} \
 		SIZE="${XSIZE}"
 

Modified: head/share/mk/local.meta.sys.mk
==============================================================================
--- head/share/mk/local.meta.sys.mk	Wed Jul 27 14:27:08 2016	(r303391)
+++ head/share/mk/local.meta.sys.mk	Wed Jul 27 14:58:15 2016	(r303392)
@@ -222,7 +222,7 @@ WITH_META_STATS= t
 .if ${MACHINE} == "host"
 MK_SHARED_TOOLCHAIN= no
 .endif
-TOOLCHAIN_VARS=	AS AR CC CLANG_TBLGEN CXX CPP LD NM OBJDUMP OBJCOPY RANLIB \
+TOOLCHAIN_VARS=	AS AR CC CLANG_TBLGEN CXX CPP LD NM OBJCOPY RANLIB \
 		STRINGS SIZE LLVM_TBLGEN
 _toolchain_bin_CLANG_TBLGEN=	/usr/bin/clang-tblgen
 _toolchain_bin_LLVM_TBLGEN=	/usr/bin/llvm-tblgen

Modified: head/share/mk/sys.mk
==============================================================================
--- head/share/mk/sys.mk	Wed Jul 27 14:27:08 2016	(r303391)
+++ head/share/mk/sys.mk	Wed Jul 27 14:58:15 2016	(r303392)
@@ -237,8 +237,6 @@ OBJCFLAGS	?=	${OBJCINCLUDES} ${CFLAGS} -
 
 OBJCOPY		?=	objcopy
 
-OBJDUMP		?=	objdump
-
 PC		?=	pc
 PFLAGS		?=
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201607271458.u6REwF1r059656>