From owner-freebsd-arch@freebsd.org Thu Aug 8 01:19:03 2019 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AAD6FBDDD3 for ; Thu, 8 Aug 2019 01:19:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 463r9z3ydxz4Zsk; Thu, 8 Aug 2019 01:19:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 0518519561; Thu, 8 Aug 2019 01:19:02 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: svn commit: r350550 - head/share/mk To: "Rodney W. Grimes" , tech-lists Cc: freebsd-arch@freebsd.org References: <201908072050.x77Ko5QD089298@gndrsh.dnsmgr.net> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <9c03a13c-8eed-06cb-bdef-faa1de8ea272@FreeBSD.org> Date: Wed, 7 Aug 2019 18:18:58 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <201908072050.x77Ko5QD089298@gndrsh.dnsmgr.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2019 01:19:03 -0000 On 8/7/19 1:50 PM, Rodney W. Grimes wrote: >> Hello, >> >> On Tue, Aug 06, 2019 at 04:56:14PM +0000, Glen Barber wrote: >> >>> I would like to request this commit be reverted. While the original >>> commit message to enable this knob stated the commit would be reverted >>> after stable/12 branched, I have seen no public complaints about >>> enabling REPRODUCIBLE_BUILD by default (and quite honestly, do not see >>> the benefit of disabling it by default -- why wouldn't we want >>> reproducibility?). >>> >>> To me, this feels like a step backwards, with no tangible benefit. >>> Note, newvers.sh does properly detect a modified tree if it can find >>> the VCS metadata directory (i.e., .git, .svn) -- I know this because >>> I personally helped with it. >>> >>> In my opinion, those that want the non-reproducible metadata included in >>> output from 'uname -a' should set WITHOUT_REPRODUCIBLE_BUILDS in their >>> src.conf. Turning off a sane default for the benefit of what I suspect >>> is likely a short list of use cases feels like a step in the wrong >>> direction. >> >> Well, my use case is that I have some machines that follow 12-stable. >> >> I'm not a developer. But I keep an eye on things like security bulletins >> etc and when they come out it usually gives something like 'affecting >> 12-STABLE prior to r something like that. And I can easily look >> at uname -a to see if this or that 12-stable machine needs to be patched >> or whatever. That is, if reproductible_build is turned off. (or >> without_reproductible_build is turned on) >> >> Or if I mail to stable@ asking for help I'll want to say *exactly* what >> sources I've built from. And sometimes someone will say "oh that was >> fixed after r" and so I'll grab sources after that revision >> if I can and fix the problem. >> >> But like I say I'm not a dev. I'd guess, though, that lots of non-devs >> use the revision info if they follow -stable, so if I'm right in thinking >> this, it'd be a short list of use cases but lots of affected people. >> >> unless there's another way to get the svn rev number? >> >> Why turn off this functionality by default? >> -- >> J. > > Actually you have a very good point here. > Let me raise the issue, the rXXXXXX is infact reproducible, why is > that being excluded from reproducible builds? If I build from the > same source at the same version I get the same rXXXXX string in > the resulting file. This is reproducible. > > So WHY are we excluding rXXXXXX from the reproducible build? We don't. The svn revision is present in uname -a even for reproducible builds. -- John Baldwin