Date: Sun, 21 Jan 2001 14:41:05 -0800 From: Julian Elischer <julian@elischer.org> To: Jason Evans <jasone@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/include mutex.h src/sys/i386/includemutex.h src/sys/kern kern_mutex.c src/sys/net if.c src/sys/sysmutex.h Message-ID: <3A6B6581.E8FFB917@elischer.org> References: <200101212234.f0LMYh716794@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jason Evans wrote:
>
> jasone 2001/01/21 14:34:43 PST
>
> Modified files:
> sys/alpha/include mutex.h
> sys/i386/include mutex.h
> sys/kern kern_mutex.c
> sys/net if.c
> sys/sys mutex.h
> Log:
> Move most of sys/mutex.h into kern/kern_mutex.c, thereby making the mutex
> inline functions non-inlined. Hide parts of the mutex implementation that
> should not be exposed.
hmmm how much performance difference is there in doing this?
I presume that we lose the optimisation of gcc removing all the unused paths
and tests when the arguments include constants. (I guess this can be
regained by giving differnt kinds of mutexes different names.)
(haven't checked the files, hope I understand what was done correnctly)
What is the reasoning? (not complaining, just curious)
>
> Make sure that WITNESS code is not executed during boot until the mutexes
> are fully initialized by SI_SUB_MUTEX (the original motivation for this
> commit).
>
> Submitted by: peter
>
> Revision Changes Path
> 1.17 +7 -1 src/sys/alpha/include/mutex.h
> 1.26 +7 -1 src/sys/i386/include/mutex.h
> 1.36 +389 -76 src/sys/kern/kern_mutex.c
> 1.97 +3 -2 src/sys/net/if.c
> 1.20 +34 -369 src/sys/sys/mutex.h
--
__--_|\ Julian Elischer
/ \ julian@elischer.org
( OZ ) World tour 2000
---> X_.---._/ from Perth, presently in: Budapest
v
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A6B6581.E8FFB917>