Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Jan 2016 12:01:30 -0600
From:      Justin Hibbits <jhibbits@freebsd.org>
To:        cem@freebsd.org
Cc:        src-committers <src-committers@freebsd.org>, svn-src-head@freebsd.org,  svn-src-all@freebsd.org
Subject:   Re: svn commit: r293039 - in head/sys/dev: sec tsec
Message-ID:  <CAHSQbTAM1cy6EyYVF4zkWRH3j4kh0tcHh0An-5WuVoy6-OxPLQ@mail.gmail.com>
In-Reply-To: <CAG6CVpX-_ZKFBO1HzhO5ftwWa6gpLW2NKeo6CoRyLAA2N3xcDw@mail.gmail.com>
References:  <201601011517.u01FHOCo079299@repo.freebsd.org> <CAG6CVpX-_ZKFBO1HzhO5ftwWa6gpLW2NKeo6CoRyLAA2N3xcDw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 1, 2016 11:30, "Conrad Meyer" <cem@freebsd.org> wrote:
>
> On Fri, Jan 1, 2016 at 7:17 AM, Justin Hibbits <jhibbits@freebsd.org>
wrote:
> > Author: jhibbits
> > Date: Fri Jan  1 15:17:24 2016
> > New Revision: 293039
> > URL: https://svnweb.freebsd.org/changeset/base/293039
> >
> > Log:
> >   Fix a couple printf formats.
> >
> > ...
> > @@ -235,7 +236,7 @@ sec_probe(device_t dev)
> >                 sc->sc_version = 3;
> >                 break;
> >         default:
> > -               device_printf(dev, "unknown SEC ID 0x%016llx!\n", id);
> > +               device_printf(dev, "unknown SEC ID 0x%16"PRIx64"!\n",
id);
> >                 return (ENXIO);
> >         }
>
> Hi,
>
> The 0 got dropped, which makes this a slightly different format.  The
> zero is ignored if a precision is given, but the 16 in the format
> string represents a field width.  (Either "%016" or "%.16" should
> print the same as the original, I think.)
>
> Best,
> Conrad

Oops, fixed in r293044.
Thanks!

-Justin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHSQbTAM1cy6EyYVF4zkWRH3j4kh0tcHh0An-5WuVoy6-OxPLQ>