From owner-freebsd-current Sat Dec 19 18:46:54 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id SAA23130 for freebsd-current-outgoing; Sat, 19 Dec 1998 18:46:54 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from bright.fx.genx.net (bright.fx.genx.net [206.64.4.154]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA23125 for ; Sat, 19 Dec 1998 18:46:50 -0800 (PST) (envelope-from bright@hotjobs.com) Received: from localhost (bright@localhost) by bright.fx.genx.net (8.9.1/8.9.1) with ESMTP id VAA16667 for ; Sat, 19 Dec 1998 21:50:24 -0500 (EST) (envelope-from bright@hotjobs.com) X-Authentication-Warning: bright.fx.genx.net: bright owned process doing -bs Date: Sat, 19 Dec 1998 21:50:24 -0500 (EST) From: Alfred Perlstein X-Sender: bright@bright.fx.genx.net To: freebsd-current@FreeBSD.ORG Subject: Someone posted a fix for NFS, but not commited In-Reply-To: <199812200157.RAA04126@dingo.cdrom.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG the file: src/sys/kern/vfs_subr.c line: 582 has a bug which can cause nfs 'intr' mounts to hang the machine: while (vp->v_numoutput) { vp->v_flag |= VBWAIT; tsleep((caddr_t)&vp->v_numoutput, slpflag | (PRIBIO + 1), "vinvlbuf", slptimeo); } it's been explained to me that if a signal interupts the tsleep it will cause an infinite loop. the fix i _think_ was: while (vp->v_numoutput) { vp->v_flag |= VBWAIT; error = tsleep((caddr_t)&vp->v_numoutput, slpflag | (PRIBIO + 1), "vinvlbuf", slptimeo); if(error){ splx(s); return(error); } } unfortunatly i accidentally deleted the mail with the fix in it and cvsup checked out the file clobbering my local copy. can someone take a look at getting this commited? it solved the hangs i was having and doesn't seem to adversly affect semantics. i have no clue where this patch went i searched the lists and had no luck finding it. thanks, Alfred Perlstein - Programmer, HotJobs Inc. - www.hotjobs.com -- There are operating systems, and then there's FreeBSD. -- http://www.freebsd.org/ 3.0-current To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message