From owner-cvs-all Fri Feb 15 8: 1:25 2002 Delivered-To: cvs-all@freebsd.org Received: from iguana.icir.org (iguana.icir.org [192.150.187.36]) by hub.freebsd.org (Postfix) with ESMTP id 058DF37B400; Fri, 15 Feb 2002 08:01:08 -0800 (PST) Received: (from rizzo@localhost) by iguana.icir.org (8.11.6/8.11.3) id g1FG16g65945; Fri, 15 Feb 2002 08:01:06 -0800 (PST) (envelope-from rizzo) Date: Fri, 15 Feb 2002 08:01:06 -0800 From: Luigi Rizzo To: Ruslan Ermilov Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/share/man/man4 Makefile Message-ID: <20020215080106.A63564@iguana.icir.org> References: <200202150836.g1F8a6P53451@freefall.freebsd.org> <20020215104025.A1139@sunbay.com> <20020215004331.B62826@iguana.icir.org> <20020215120056.A13211@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020215120056.A13211@sunbay.com> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Feb 15, 2002 at 12:00:56PM +0200, Ruslan Ermilov wrote: > On Fri, Feb 15, 2002 at 12:43:31AM -0800, Luigi Rizzo wrote: > > On Fri, Feb 15, 2002 at 10:40:26AM +0200, Ruslan Ermilov wrote: > > > > (wonder why the process cannot be made automatic...) > > > > > > > What do you mean? > > > > couldn't the Makefile derive a tentative list of targets by doing > > > > MAN=`ls *.4` > > > This would be bogus for a variety of reasons: > > 1. != type of assignment means ls(1) should be present in PATH during > installworld, and we don't have it there (${STRICTTMPPATH}:${INSTALLTMP}). this is a very weak motivation. we already need a lot of stuff to be in the path during the install (make, cp, compiler, mkdir, install, ...) so i guess making sure there is ls as well command is no big deal. For what matters, "echo *.4" (shell builtin) would do the job. As for removing entries, of course we can use variable expansions (maybe after creating the initial list, just to avoid cluttering too much the code), and possibly put something in the *.mk files which computes set differences. cheers luigi > There are some places where != should not be actually used, and I > will eventually clean then up. It's not normally a problem because > make(1) considers a non-zero exit value as non-fatal, and we don't > usually use != results at `install' phase. > > 2. This would make it impossible to exclude some manpages from build, > given a good reason. > > > and then using special cases to add/remove non-conforming filenames ? > > > You can't remove without using the := type of assigmenent. > > > Cheers, > -- > Ruslan Ermilov Sysadmin and DBA, > ru@sunbay.com Sunbay Software AG, > ru@FreeBSD.org FreeBSD committer, > +380.652.512.251 Simferopol, Ukraine > > http://www.FreeBSD.org The Power To Serve > http://www.oracle.com Enabling The Information Age > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message