Date: Mon, 18 Jan 2016 16:10:23 +0100 (CET) From: Jimmy Olgeni <olgeni@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r404810 - head/devel/elixir-timex Message-ID: <alpine.BSF.2.20.1601181512390.16039@backoffice.olgeni.com> In-Reply-To: <20160113153748.GA38723@FreeBSD.org> References: <201512300841.tBU8fsYI090905@repo.freebsd.org> <20160113153748.GA38723@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 13 Jan 2016, Alexey Dokuchaev wrote: > On Wed, Dec 30, 2015 at 08:41:54AM +0000, Jimmy Olgeni wrote: > > New Revision: 404810 > > URL: https://svnweb.freebsd.org/changeset/ports/404810 > > > > Log: > > Upgrade devel/elixir-timex to version 1.0.0. > > > > [...] > > @@ -1,7 +1,8 @@ > > # $FreeBSD$ > > > > PORTNAME= timex > > -DISTVERSION= 1.0.0-rc4 > > +PORTVERSION= 1.0.0 > > +PORTEPOCH= 1 > > Why did you bump port epoch here? DISTVERSION ensures that resulting > PORTVERSION is correctly mangled, and used for -betas and -rcs because > it allows seamless update to subsequent .0 releases: > > $ make -V PORTVERSION DISTVERSION=1.0.0-rc4 > 1.0.0.r4 > $ pkg version -t 1.0.0.r4 1.0.0 > < I knew about DISTVERSION, but then I figured that 1.0.0.r4 would be greater than 1.0.0 in the version comparison, and I didn't think about pkg version -t. And I even thought about it. I surely made a couple more of these around the same time :( > What's even more strange is that I've made a very similar complaint to > cy@ on Decemlber 9th WRT r403347. All committers should read svn-* lists, > how come you've missed it? :-( I try to keep up to date and star useful messages from svn-* for later reference, but between two jobs sometimes time runs short and I miss a batch. Having to say things twice is pretty much like pressing ^T on Linux, so I do get your point. Now I made a sieve rule to make sure that all replies to svn-* end up directly into my INBOX, so I can see at a glance if there are any comments to commit messages. Seems to be working so far. In the meantime, thanks a lot for keeping an eye on things :) -- jimmy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.20.1601181512390.16039>