Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Nov 2018 16:28:09 +0000 (UTC)
From:      Maxim Sobolev <sobomax@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r340220 - head/sys/geom
Message-ID:  <201811071628.wA7GS9RQ081820@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: sobomax
Date: Wed Nov  7 16:28:09 2018
New Revision: 340220
URL: https://svnweb.freebsd.org/changeset/base/340220

Log:
  Revert r340187, it breaks EOD (end-of-device) detection logic. Turns out,
  i/o into last_sector+N is handled differently for N==1 and N>1 cases to
  accomodate that, so some other approach would be needed to fix DIOCGDELETE
  ioctl(2).

Modified:
  head/sys/geom/geom_io.c

Modified: head/sys/geom/geom_io.c
==============================================================================
--- head/sys/geom/geom_io.c	Wed Nov  7 16:22:18 2018	(r340219)
+++ head/sys/geom/geom_io.c	Wed Nov  7 16:28:09 2018	(r340220)
@@ -420,8 +420,6 @@ g_io_check(struct bio *bp)
 			return (EIO);
 		if (bp->bio_offset > pp->mediasize)
 			return (EIO);
-		if (bp->bio_offset == pp->mediasize && bp->bio_length > 0)
-			return (EIO);
 
 		/* Truncate requests to the end of providers media. */
 		excess = bp->bio_offset + bp->bio_length;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811071628.wA7GS9RQ081820>