From owner-freebsd-current Sun Sep 22 15:11:13 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 668F637B401; Sun, 22 Sep 2002 15:11:12 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9854443E3B; Sun, 22 Sep 2002 15:11:09 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.3/8.12.3) with ESMTP id g8MMAm9R094969; Sun, 22 Sep 2002 16:10:55 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 22 Sep 2002 16:10:35 -0600 (MDT) Message-Id: <20020922.161035.66904327.imp@bsdimp.com> To: mb@imp.ch Cc: smckay@internode.on.net, mbr@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci if_dc.c From: "M. Warner Losh" In-Reply-To: References: <200209221409.g8ME9DB16763@dungeon.home> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: Martin Blapp writes: : : Hi, : : > ... I thought I should explicitly mention that merging this particular : > change as it stands is a bad idea because PNIC and Davicom cards (at least) : > are not yet correctly handled. The code in -stable is the old broken but : > apparently harmless code. This new code is attempting to be more correct : > but breaks support for some cards. Odd situation, no? : : What chips do have these card ? We can just do this check for the admtek : cards, can we ? : : Have we now different cards with the same chips but different behaviour ??? : : I know that a : : 981 : 983 : 983b : 985 : : admtek chip exist. I have a similar problem with the Abocom FE2500 chip that's in one of my cardbus cards. Or maybe I'm confusing the two recent commits... Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message