From owner-svn-ports-head@FreeBSD.ORG  Tue Apr  7 07:24:03 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id DA7FF53A; Tue,  7 Apr 2015 07:24:03 +0000 (UTC)
Date: Tue, 7 Apr 2015 07:24:03 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Don Lewis <truckman@FreeBSD.org>
Subject: Re: svn commit: r383472 - head/audio/muse
Message-ID: <20150407072403.GA54371@FreeBSD.org>
References: <20150407012902.GA22994@FreeBSD.org>
 <201504070631.t376VnAp041310@gw.catspoiler.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201504070631.t376VnAp041310@gw.catspoiler.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: sunpoet@FreeBSD.org, svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org,
 ports-committers@FreeBSD.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2015 07:24:04 -0000

On Mon, Apr 06, 2015 at 11:31:49PM -0700, Don Lewis wrote:
> On  7 Apr, Alexey Dokuchaev wrote:
> > On Mon, Apr 06, 2015 at 06:59:20PM +0000, Sunpoet Po-Chuan Hsieh wrote:
> >> New Revision: 383472
> >> [...]
> >> -	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
> >> +	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
> > 
> > Please do not change working and readable code into equivalent
> > less-readable one.
> 
> I'm not particularly fond of either the original or the update, but the
> original is obscure enough that I'd have to dig out the manual to figure
> out what it even does.

Yes, *in general* in-var substitutions can be cryptic, and I've outlined
it already that I'm in the "always :S, no thinking required".  That said,
we should know our tools, make(1) in this case, and not be afraid to use
its features, and also: this particular trick is used a lot in the ports
tree already and thus should not surprise any seasonal developer and/or
contributor.

./danfe