From owner-freebsd-bugs@FreeBSD.ORG Fri Nov 23 20:08:24 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF00C16A420; Fri, 23 Nov 2007 20:08:24 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A5D0513C465; Fri, 23 Nov 2007 20:08:24 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from freefall.freebsd.org (alc@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lANK8Om0070547; Fri, 23 Nov 2007 20:08:24 GMT (envelope-from alc@freefall.freebsd.org) Received: (from alc@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lANK8OYp070543; Fri, 23 Nov 2007 20:08:24 GMT (envelope-from alc) Date: Fri, 23 Nov 2007 20:08:24 GMT Message-Id: <200711232008.lANK8OYp070543@freefall.freebsd.org> To: gemini@geminix.org, alc@FreeBSD.org, freebsd-bugs@FreeBSD.org From: alc@FreeBSD.org Cc: Subject: Re: kern/71792: [vm] [patch] Wrong/missing 'goto' target label in contigmalloc1() X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2007 20:08:24 -0000 Synopsis: [vm] [patch] Wrong/missing 'goto' target label in contigmalloc1() State-Changed-From-To: open->closed State-Changed-By: alc State-Changed-When: Fri Nov 23 19:57:04 UTC 2007 State-Changed-Why: I am sure that the use of the same label was intentional and not accidental. The reason being that a new page might appear in the inactive queue while contigmalloc() slept on an active page. Also, in the audit trail, there is mention of a fix for an endless loop in this code that was applied to DragonflyBSD. FreeBSD has had a similar fix since FreeBSD 5.0. http://www.freebsd.org/cgi/query-pr.cgi?pr=71792