From owner-freebsd-current@freebsd.org Sun Aug 11 07:04:10 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C38F6B1AD6 for ; Sun, 11 Aug 2019 07:04:10 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 465qhn6S91z4f3L for ; Sun, 11 Aug 2019 07:04:09 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x42e.google.com with SMTP id z1so101860731wru.13 for ; Sun, 11 Aug 2019 00:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=ohLeNyh+YTqCClrlWhpoRGFwP0ZGYR0ktwiVnpycr5o=; b=NVrbZrGp1qWkGE/eqx1gGG1ZOlhUq1L9NbNouCCejXr34a5Jr5BQAjlb5U5EjGb6Sr kmU6i6OHnqmkdRwJ0H1mf2MYTq+zIWHmVq+JjvdX0zAZ5EbC/48Vt+S4IczIws6aapnS A5aXqPSVYM7mbLZdjIHhueo1LjBMkd+2B/ZEBfyQt3SQK3+ftWBybQVvqh6HO+fUgSv9 Mn4JHnigmoaaTxMN+Xn70l9HeJGPxkO0CkSmxxpSH/usGSRCeZmjjxCAI6pSkuwvW1R3 kIb1r3SV2SVUiSNMxXQ8Jk+XkONjoDrDhqnu0G6h7jrvGbZjFVGx4Zly8MQytNoHwENl /B/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=ohLeNyh+YTqCClrlWhpoRGFwP0ZGYR0ktwiVnpycr5o=; b=M4jtRngSNEACeGMdVqVt2TvFs/phu1guCw8cawHytAJD06UAeBfDOXCeYY5e4sytC3 gLWv9sk32Y5ZWpMdHkhmuNrnv5C4beYY+fGxtvOPyg40587+K8tpnT3OjPeFmQkBzEoj C7SeA3kbDrVg2fr4stJkvDhuHnRrSuGw0FFvvUly9iZ+8z2aETHSjKtG28l4V8E0hl3G VpAAahnROR3E2skD/SSCcs5kRvrYRxqCBq3/vVR7JgL3XWjGPWVrDXJ4UesGqzKkPi2i BmP/GUzc5ClRJHBVE3TmMAbRY0lq2VWwvToi8kPLVmwzrSchlIJZ1IFSc1VhLn/NYQdK At4Q== X-Gm-Message-State: APjAAAVKZgvn6bq9AQ2+N2Avu9HRVUOTisa4Ox2CfG/IxSg98GU4BNeO o3+VpM8AIim8/bQinvy4eYI= X-Google-Smtp-Source: APXvYqwoJ3xXquRWTZk7nNSt6U4+ww6ssDp0xXLCfATFizsBt4CMriolUcN0dngnd9KebVPl+FgDPQ== X-Received: by 2002:a5d:4703:: with SMTP id y3mr18828468wrq.63.1565507047607; Sun, 11 Aug 2019 00:04:07 -0700 (PDT) Received: from ernst.home (p5B3BE66A.dip0.t-ipconnect.de. [91.59.230.106]) by smtp.gmail.com with ESMTPSA id v124sm16911671wmf.23.2019.08.11.00.04.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 11 Aug 2019 00:04:06 -0700 (PDT) Date: Sun, 11 Aug 2019 09:04:05 +0200 From: Gary Jennejohn To: Rick Macklem Cc: "freebsd-current@FreeBSD.org" Subject: Re: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? Message-ID: <20190811090405.50cc49b1@ernst.home> In-Reply-To: References: Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 465qhn6S91z4f3L X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NVrbZrGp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gljennjohn@gmail.com designates 2a00:1450:4864:20::42e as permitted sender) smtp.mailfrom=gljennjohn@gmail.com X-Spamd-Result: default: False [-2.99 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[gljennjohn@gmail.com]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RECEIVED_SPAMHAUS_PBL(0.00)[106.230.59.91.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; FREEMAIL_REPLYTO(0.00)[gmail.com]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[e.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-9.14), ipnet: 2a00:1450::/32(-3.05), asn: 15169(-2.40), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 07:04:10 -0000 On Sun, 11 Aug 2019 02:03:10 +0000 Rick Macklem wrote: > Hi, > > I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a file that > resides in a file system that does not support holes, ENOTTY is returned. > > This error isn't listed for lseek() and seems a liitle weird. > ENOTTY is the standard error return for an unimplemented ioctl(2), and SEEK_HOLE ultimately becomes a call to fo_ioctl(). > I can see a couple of alternatives to this: > 1 - Return a different error. Maybe ENXIO? > or > 2 - Have lseek() do the trivial implementation when the VOP_IOCTL() fails. > - For SEEK_DATA, just return the offset given as argument and for SEEK_HOLE > return the file's size as the offset. > > What do others think? rick > ps: The man page should be updated, whatever is done w.r.t. this. > I also vote for option 2 -- Gary Jennejohn