Date: Thu, 22 Aug 2002 12:15:25 +1000 (EST) From: Edwin Groothuis <edwin@mavetju.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/41873: [patch] let bsd.gnomeng.mk complain when USE_GNOME is incorrect Message-ID: <20020822021525.396506A7124@k7.mavetju>
next in thread | raw e-mail | index | archive | help
>Number: 41873
>Category: ports
>Synopsis: [patch] let bsd.gnomeng.mk complain when USE_GNOME is incorrect
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Aug 21 19:20:03 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Edwin Groothuis
>Release: FreeBSD 4.5-RELEASE i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju 4.5-RELEASE FreeBSD 4.5-RELEASE #3: Mon Mar 11 13:32:05 EST 2002 edwin@k7.mavetju.org:/usr/src/sys/compile/k7 i386
$FreeBSD: ports/Mk/bsd.gnomeng.mk,v 1.14 2002/07/25 15:36:21 marcus Exp $
>Description:
When reading the message regarding bsd.gnomeng.mk and looking through
my list of ports to find out what has to be modified I stumbled
into a small problem: despite that I had "USE_GNOME=gtk", it didn't
check for the GTK-libraries!
Of course this was an error from me, it should have been
"USE_GNOME=gtk12". To prevent people from filling out wrong values
in the USE_GNOME fields, it could/should check for correct values.
>How-To-Repeat:
See description
>Fix:
Right now there are two fields for every GNOME component: xxx_LIB_DEPENDS
and xxx_DETECT. I've choosen for xxx_LIB_DEPENDS for no obvious reason.
--- Mk/bsd.gnomeng.mk-old Thu Aug 22 11:59:49 2002
+++ Mk/bsd.gnomeng.mk Thu Aug 22 12:12:27 2002
@@ -246,6 +246,9 @@
# Then use already expanded USE_GNOME_IMPL to expand USE_GNOME
. for component in ${USE_GNOME}
+. if !defined(${component}_LIB_DEPENDS)
+BROKEN="Don't know about USE_GNOME=${component}"
+. endif
_USE_GNOME+= ${${component}_USE_GNOME_IMPL} ${component}
. endfor
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020822021525.396506A7124>