From owner-freebsd-ports Wed Aug 21 19:20:13 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 309B237B400 for ; Wed, 21 Aug 2002 19:20:05 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5AE843E4A for ; Wed, 21 Aug 2002 19:20:03 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7M2K3JU048667 for ; Wed, 21 Aug 2002 19:20:03 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7M2K3NB048666; Wed, 21 Aug 2002 19:20:03 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 313B837B400 for ; Wed, 21 Aug 2002 19:16:09 -0700 (PDT) Received: from topaz.mdcc.cx (topaz.mdcc.cx [212.204.230.141]) by mx1.FreeBSD.org (Postfix) with ESMTP id B9E5543E65 for ; Wed, 21 Aug 2002 19:16:08 -0700 (PDT) (envelope-from edwin@mavetju.org) Received: from k7.mavetju (topaz.mdcc.cx [212.204.230.141]) by topaz.mdcc.cx (Postfix) with ESMTP id F3CC72B912 for ; Thu, 22 Aug 2002 04:15:54 +0200 (CEST) Received: by k7.mavetju (Postfix, from userid 1001) id 396506A7124; Thu, 22 Aug 2002 12:15:25 +1000 (EST) Message-Id: <20020822021525.396506A7124@k7.mavetju> Date: Thu, 22 Aug 2002 12:15:25 +1000 (EST) From: Edwin Groothuis Reply-To: Edwin Groothuis To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/41873: [patch] let bsd.gnomeng.mk complain when USE_GNOME is incorrect Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 41873 >Category: ports >Synopsis: [patch] let bsd.gnomeng.mk complain when USE_GNOME is incorrect >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Aug 21 19:20:03 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Edwin Groothuis >Release: FreeBSD 4.5-RELEASE i386 >Organization: - >Environment: System: FreeBSD k7.mavetju 4.5-RELEASE FreeBSD 4.5-RELEASE #3: Mon Mar 11 13:32:05 EST 2002 edwin@k7.mavetju.org:/usr/src/sys/compile/k7 i386 $FreeBSD: ports/Mk/bsd.gnomeng.mk,v 1.14 2002/07/25 15:36:21 marcus Exp $ >Description: When reading the message regarding bsd.gnomeng.mk and looking through my list of ports to find out what has to be modified I stumbled into a small problem: despite that I had "USE_GNOME=gtk", it didn't check for the GTK-libraries! Of course this was an error from me, it should have been "USE_GNOME=gtk12". To prevent people from filling out wrong values in the USE_GNOME fields, it could/should check for correct values. >How-To-Repeat: See description >Fix: Right now there are two fields for every GNOME component: xxx_LIB_DEPENDS and xxx_DETECT. I've choosen for xxx_LIB_DEPENDS for no obvious reason. --- Mk/bsd.gnomeng.mk-old Thu Aug 22 11:59:49 2002 +++ Mk/bsd.gnomeng.mk Thu Aug 22 12:12:27 2002 @@ -246,6 +246,9 @@ # Then use already expanded USE_GNOME_IMPL to expand USE_GNOME . for component in ${USE_GNOME} +. if !defined(${component}_LIB_DEPENDS) +BROKEN="Don't know about USE_GNOME=${component}" +. endif _USE_GNOME+= ${${component}_USE_GNOME_IMPL} ${component} . endfor >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message