Date: Wed, 07 Jan 2015 09:08:53 -0500 From: Anthony Jenkins <Anthony.B.Jenkins@att.net> To: Adrian Chadd <adrian@freebsd.org> Cc: Anthony Jenkins <Scoobi_doo@yahoo.com>, "wireless@freebsd.org" <wireless@freebsd.org> Subject: Re: Atheros AR9565 detected, not working Message-ID: <54AD3DF5.1070905@att.net> In-Reply-To: <CAJ-VmonaSP5sOSii6HWUHwuTxd_30dXv%2BhH6ZDEVNzHopj9vLA@mail.gmail.com> References: <CAJ-Vmo=rLMaatYY692fzc2CF2iiEXM9Fd5DZZpJTWOD_6mHpQg@mail.gmail.com> <433678684.160603.1419257025708.JavaMail.yahoo@jws10658.mail.bf1.yahoo.com> <CAJ-Vmom9zW9eeWvZ8KrpgYWS_MFQ46S1eOd4aUiOQ1S3P%2BbyNA@mail.gmail.com> <54987366.6060803@yahoo.com> <CAJ-VmomUoY3y5vtB88H4eugX01VVWMuuLf1gXsUS4Wptv8jh2Q@mail.gmail.com> <5498780B.90704@yahoo.com> <CAJ-Vmo=eaKGG9ha99%2B5gGdOE7OxkKq9RG3auc-2VP=ES0bvGmw@mail.gmail.com> <5498944C.4040706@yahoo.com> <CAJ-VmonQsa=D52esXPiEY_csngXrA8n3hGZoS9ix1o-RAC_uEA@mail.gmail.com> <CAJ-VmonaSP5sOSii6HWUHwuTxd_30dXv%2BhH6ZDEVNzHopj9vLA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Adrian,
Just letting you know I haven't died in a shootout with the US FBI or anything, just been working on (and suprisingly fixing) issues with my HP Envy Sleekbook 6 since the holidays. I'll be cleaning up my patches and posting to the wiki this week (hopefully). Also still sitting on that ACPI patch for the RTC CMOS handler.
> So, would you mind trying your patch again but only with the bits that
> allow the GPIO pins to be enabled? If that works, then I'll commit
> that
Just to be clear, instead of commenting out the early exits in the GPIO readers/writers for certain GPIO addresses, I should selectively give the AR9565 a pass? ...or do you want me to /just/ comment out the early exits, and revert the added call to ar9300_enable_rf_kill() and see if that works? I don't like those early exit bits anyway...
> In parallel I'm going to have to tidy up the rfkill capability
> API to correctly set bits - I'll likely expand the field in the driver
> and have the pre-AR9300 chipset code error out if an out-of-bounds
> gpio value is sent.
Excellent! Anything I can help with? We /have/ an rfkill API? ...because I need some way to connect my newly-fixed laptop wifi-enable key to some function to enable/disable the radios. Right now I'm just throwing an event over to devd(8).
Thanks,
Anthony
On 12/23/2014 13:06, Adrian Chadd wrote:
> On 22 December 2014 at 14:57, Adrian Chadd <adrian@freebsd.org> wrote:
>
>> Ok, let me go see what's going on.
> I dislike when I say "let me see what's going on" and then I .. see
> what's going on.
>
> So:
>
> * the ar5212 HAL does the right thing - it checks the rfkill setup in
> ar5212Reset() and enables it if required
> * it also populates the rfkill data from EEPROM at attach time
> * the sysctl code just grabs the rfkill /eeprom field/ and .. well,
> that's the API. So I have to see if that's the same for the AR9300 or
> not. Grr.
>
> Well, it kinda is:
>
> ar9300eep.h:#define EEP_RFSILENT_ENABLED 0x0001 /* bit 0:
> enabled/disabled */
> ar9300eep.h:#define EEP_RFSILENT_ENABLED_S 0 /* bit 0:
> enabled/disabled */
> ar9300eep.h:#define EEP_RFSILENT_POLARITY 0x0002 /* bit 1: polarity */
> ar9300eep.h:#define EEP_RFSILENT_POLARITY_S 1 /* bit 1: polarity */
> ar9300eep.h:#define EEP_RFSILENT_GPIO_SEL 0x00fc /* bits 2..7:
> gpio PIN */
> ar9300eep.h:#define EEP_RFSILENT_GPIO_SEL_S 2 /* bits 2..7:
> gpio PIN */
>
> .. but on the AR5212:
>
> ../ah_eeprom_v1.h:#define AR_EEPROM_RFSILENT_GPIO_SEL 0x001c
> ../ah_eeprom_v1.h:#define AR_EEPROM_RFSILENT_GPIO_SEL_S 2
> ../ah_eeprom_v1.h:#define AR_EEPROM_RFSILENT_POLARITY 0x0002
> ../ah_eeprom_v1.h:#define AR_EEPROM_RFSILENT_POLARITY_S 1
> ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT 0x0f /* RF
> Silent/Clock Run Enable */
> ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT_GPIO_SEL 0x001c
> ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT_GPIO_SEL_S 2
> ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT_POLARITY 0x0002
> ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT_POLARITY_S 1
>
> .. so more bits are available on the ar9300. I have to check the
> AR5416 too; maybe more bits are also available there.
>
> Grr!
>
> * Then, the Ar5212 is doing it in ar5212Reset(), but ar5416Reset()
> isn't doing it! So I'm going to have to go and hook that up for the
> AR5416, AR9160, AR9280, AR9285, AR9287. Ugh.
>
> * the ar9300 HAL on -HEAD has this in ar9300_reset():
>
> /* Reset ier reference count to disabled */
> // OS_ATOMIC_SET(&ahp->ah_ier_ref_count, 1);C
> if (ath_hal_isrfkillenabled(ah)) {
> ar9300_enable_rf_kill(ah);
> }
>
> .. so it should be enabling it at reset. We shouldn't need to enable
> it during ar9300_attach() as the first reset will set it up.
>
> * The AR5212 HAL enables rfkill interrupts, but the AR9300 doesn't.
> Apparently there are .. issues. I don't know what they are. So maybe
> we should use polling on that particular GPIO pin to provide rfkill
> feedback to the driver and eventually the network stack.
>
> So, would you mind trying your patch again but only with the bits that
> allow the GPIO pins to be enabled? If that works, then I'll commit
> that. In parallel I'm going to have to tidy up the rfkill capability
> API to correctly set bits - I'll likely expand the field in the driver
> and have the pre-AR9300 chipset code error out if an out-of-bounds
> gpio value is sent.
>
> Thanks!
>
>
>
> -adrian
> _______________________________________________
> freebsd-wireless@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-wireless
> To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org"
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54AD3DF5.1070905>