From owner-svn-ports-head@FreeBSD.ORG Tue Apr 7 07:28:00 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7EED7650; Tue, 7 Apr 2015 07:28:00 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5083BE99; Tue, 7 Apr 2015 07:27:59 +0000 (UTC) Received: from [192.168.1.22] (159.Red-79-148-64.dynamicIP.rima-tde.net [79.148.64.159]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 7004F435C7; Tue, 7 Apr 2015 02:27:56 -0500 (CDT) Message-ID: <552386FA.7030007@marino.st> Date: Tue, 07 Apr 2015 09:27:54 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r383472 - head/audio/muse References: <201504061859.t36IxK0v000969@svn.freebsd.org> <20150407012902.GA22994@FreeBSD.org> <91AB85D3-A8DE-491C-A2D7-4E8D7E1CDC12@adamw.org> <20150407023204.GA44784@FreeBSD.org> <552376AD.7010903@marino.st> <20150407070711.GA90710@FreeBSD.org> In-Reply-To: <20150407070711.GA90710@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Sunpoet Po-Chuan Hsieh , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Adam Weinberger X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2015 07:28:00 -0000 On 4/7/2015 09:07, Alexey Dokuchaev wrote > > No, it's not "just because", not sure why you didn't quote it: "As I've > previously had explained, "cd ${WRKSRC} && ${INSTALL_DATA}" is two- > command construct (vs. single, $cwd-agnostic command), compound cd commands are typically easier to read on logs, particularly if it removes a loop. > it typically gets > longer and thus can cause line wrapping, Avoiding line wrapping is not a good reason > but most importantly that it > should not have been committed in the first place as being gratuitous > change." You've already gotten feedback from 3 people that they prefer the new version, so that's hardly gratuitous. > We do not avoid making changes merely for annotations' sake. But we do > if the change is gratuitous. It also helps to maintain claner, easier > to review diffs, and does not needlessly blow the repo size (in the long > run it might make a difference). The problem is that you've defined gratuitous based on if it affects annotations in some cases. Most of the stuff you've pushed back on, I saw as an improvement if taken in standalone. So you are advocating keeping inferior structures for the sake of annotation. > John, with all due respect, but the fact that you do not find annonation > feature useful does not mean other people think it's useless. Also, "svn > blame" is not just a command some of us like while others don't, it's a > nice and easily comprehensible reason for why we try to avoid repo churn. I would say "if all things being equal" avoid churn with a very low threshold. You threshold for equal is high, thus the conflict. This desire to avoid change at all cost seems to be interfering with the right thing. There's only 3 cases: 1) the maintainer is doing it himself (not your business) 2) somebody is maintaining a ports@FreeBSD.org (I'd prefer it get maintained rather than nothing, e.d. tkato's case) 3) somebody is committing on a maintained port that is not theirs. (Here is where your svn blame concern has the most validity) ports@FreeBSD.org ports are one step above deprecation. Just let drive-by fixers do their job on unwanted ports without giving them too much grief. That's my opinion. John