From nobody Fri Oct 8 13:07:38 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5997F12D6A6B for ; Fri, 8 Oct 2021 13:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HQpQ21kRnz4S63 for ; Fri, 8 Oct 2021 13:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1B9922744D for ; Fri, 8 Oct 2021 13:07:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 198D7c2S046270 for ; Fri, 8 Oct 2021 13:07:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 198D7cwG046269 for ports-bugs@FreeBSD.org; Fri, 8 Oct 2021 13:07:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 259005] Mk/Scripts/qa.sh: Spurious SONAME warnings due to pipefail Date: Fri, 08 Oct 2021 13:07:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: henrik@gulbra.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform bug_file_loc op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259005 Bug ID: 259005 Summary: Mk/Scripts/qa.sh: Spurious SONAME warnings due to pipefail Product: Ports & Packages Version: Latest Hardware: Any URL: https://reviews.freebsd.org/D31211 OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: henrik@gulbra.net Created attachment 228517 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D228517&action= =3Dedit qa_soname_pipefail.diff The recently added "set -o pipefail" at the top of Mk/Scripts/qa.sh breaks the exit status for pipelines where long texts are piped into "grep -q", as explained in the comments for PR 167009 and elaborated on elsewhere ( https://reviews.freebsd.org/D31211 ). This produces lots of incorrect SONAME warnings during stage-qa for at least some ports and systems. I have been waiting for someone to patch this, but since the problem still exists in the current tree, it is probably best to offer my own patch, if only to have an open bug report for the issue. There are other instances of the "| grep -q" pattern in qa.sh, but it looks like the remaining examples have single-line input texts, which are unlikely to trigger this bug. I think we can keep those unchanged. --=20 You are receiving this mail because: You are the assignee for the bug.=