Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Jun 2002 20:36:35 +0400
From:      "Andrey A. Chernov" <ache@nagual.pp.ru>
To:        Dag-Erling Smorgrav <des@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/crypto/openssh LICENCE auth-krb4.c auth-krb5.c auth-passwd.c auth-rh-rsa.c auth-rsa.c auth-skey.c auth.c auth.h auth1.c auth2-chall.c auth2.c authfd.c authfile.c bufaux.c canohost.c channels.c channels.h cipher.c cipher.h compat.c ...
Message-ID:  <20020623163631.GB36907@nagual.pp.ru>
In-Reply-To: <20020623161748.GA36907@nagual.pp.ru>
References:  <200206231609.g5NG9AO66770@freefall.freebsd.org> <20020623161748.GA36907@nagual.pp.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 23, 2002 at 20:17:51 +0400, Andrey A. Chernov wrote:
> On Sun, Jun 23, 2002 at 09:09:10 -0700, Dag-Erling Smorgrav wrote:
> >   
> >    - sshd fails to set TERM correctly.
> 
> Do you merge our login.conf modifications in? I not check it yet, but it 
> can be the reason.

Just check it, my guess is right, our changes are not merged properly.
It means that not only TERM is not set correctly, but all login.conf 
variables are missing too. Quick check shows that session.c 1.29 have:

env = do_setusercontext(s);

But 1.30 (and original code) have

do_setusercontext(pw);

do_setusercontext() must return env to handle all LOGIN_CAP things. Please 
reestore our code in more correct way. Every change in session.c is for 
reason and must be inherited.

P.S. That is the thing constantly wonder me. You are not only one who
forget to save our changes in session.c across OpenSSH update. Previous
people constantly forget the same changes too. I don't understand, why. 
Diff perfectly indicates them. What is hard with it?

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020623163631.GB36907>