Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Mar 2019 19:24:51 +0000 (UTC)
From:      Jan Beich <jbeich@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r494635 - head/graphics/dspdfviewer/files
Message-ID:  <201903041924.x24JOpCs013442@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jbeich
Date: Mon Mar  4 19:24:51 2019
New Revision: 494635
URL: https://svnweb.freebsd.org/changeset/ports/494635

Log:
  graphics/dspdfviewer: partially unbreak with Clang 8
  
  ../dspdfviewer.cpp:311:48: error: empty expression statement has no effect; remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt]
    QSize newSize = window.getPreviewImageSize();;
                                                 ^
  
  PR:		236217
  Approved by:	portmgr blanket

Added:
  head/graphics/dspdfviewer/files/patch-dspdfviewer.cpp   (contents, props changed)

Added: head/graphics/dspdfviewer/files/patch-dspdfviewer.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/graphics/dspdfviewer/files/patch-dspdfviewer.cpp	Mon Mar  4 19:24:51 2019	(r494635)
@@ -0,0 +1,17 @@
+Fix build with Clang 8:
+
+../dspdfviewer.cpp:311:48: error: empty expression statement has no effect; remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt]
+  QSize newSize = window.getPreviewImageSize();;
+                                               ^
+
+--- dspdfviewer.cpp.orig	2016-09-13 13:18:47 UTC
++++ dspdfviewer.cpp
+@@ -308,7 +308,7 @@ RenderingIdentifier DSPDFViewer::toRenderIdent(unsigne
+ 
+ RenderingIdentifier DSPDFViewer::toThumbnailRenderIdent(unsigned int pageNumber, PDFViewerWindow& window)
+ {
+-  QSize newSize = window.getPreviewImageSize();;
++  QSize newSize = window.getPreviewImageSize();
+   static QSize thumbnailSize;
+   if ( thumbnailSize != newSize ) {
+     DEBUGOUT << "Thumbnail size changed from" << thumbnailSize << "to" << newSize;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903041924.x24JOpCs013442>