Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 May 1995 17:15:42 +0400 (MSD)
From:      "Andrey A. Chernov, Black Mage" <ache@astral.msk.su>
To:        "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Cc:        CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com
Subject:   Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c
Message-ID:  <oC-FrjluZ2@astral.msk.su>
In-Reply-To: <199505150656.XAA05295@gndrsh.aac.dev.com>; from "Rodney W. Grimes" at Sun, 14 May 1995 23:56:43 -0700 (PDT)
References:  <199505150656.XAA05295@gndrsh.aac.dev.com>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <199505150656.XAA05295@gndrsh.aac.dev.com> Rodney W. Grimes
    writes:

>> 
>> ache        95/05/14 17:03:33
>> 
>>   Modified:    usr.bin/rpcgen  rpc_parse.c
>>   Log:
>>   End of listcan be not marked, fix it
>>   Submitted by: Kai Vorma <vode@snakemail.hut.fi>

>I would really like to see commits being review at this stage of the
>game.  Even Jordan, David, myself, and PHK are having almost all of
>our work reviewed by 1 if not 2 other folks.

>I saw this report come in, though about it, and basically decided it
>was not ``critical enough'' to fix at this time in the game give the
>risk factor we are operating under.

>Since you may know more about the rpc code, I will let this patch
>stand for now, but please, let's all get every thing we do from here
>until the code FREEZE is lifted reviewed by someone else after we
>think it looks like a valid thing to be done.

Rod, previously you write different things: only kernel and /usr/src/Makefile
targets commits must be reviewd by 2 or more peoples (just read your announce),
it is bad tone to change policy on the fly.
I am smart enough to not commit suspicious thing at this stage or
conslut with others about suspicious things. About this patch:
I carefully check code flow and find that old code
is definitely broken.

-- 
Andrey A. Chernov        : And I rest so composedly,  /Now, in my bed,
ache@astral.msk.su       : That any beholder  /Might fancy me dead -
FidoNet: 2:5020/230.3    : Might start at beholding me,  /Thinking me dead.
RELCOM Team,FreeBSD Team :         E.A.Poe         From "For Annie" 1849



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?oC-FrjluZ2>