From owner-svn-src-head@freebsd.org Sun Oct 14 17:34:48 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E848810DC95F; Sun, 14 Oct 2018 17:34:47 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2614A93DEE; Sun, 14 Oct 2018 17:34:47 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id BkHpgLXhx5HxqBkHrgRj57; Sun, 14 Oct 2018 11:34:44 -0600 X-Authority-Analysis: v=2.3 cv=BMcHU2YG c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=smKx5t2vBNcA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=4Cvd4rCqXY8IQkmsnL4A:9 a=nPIZNYLz3_kZIvjP:21 a=QWIVYixRJyHsJuYc:21 a=QEXdDO2ut3YA:10 a=8msJMu4u7WDcyy4PkWUA:9 a=OxBtRJrlC-9Wvona:21 a=9ss-RqM5ZaIXugqW:21 a=gwKWubycPRIv2dC6:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [25.82.157.51] (unknown [24.244.29.129]) by spqr.komquats.com (Postfix) with ESMTPSA id 282E52DF8; Sun, 14 Oct 2018 10:34:41 -0700 (PDT) MIME-Version: 1.0 From: Cy Schubert Subject: RE: svn commit: r339355 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Date: Sun, 14 Oct 2018 11:34:50 -0600 To: Mateusz Guzik , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <20181014173441.282E52DF8@spqr.komquats.com> X-CMAE-Envelope: MS4wfOckEMD+ZyhIbGaCoCjDmEargSpGhTWzB+GNanGA3BLHNO3O+dauvJQU3iN8GmcJwd5yugo7+LV3s8koXwcpcyaBl/WsxlkviMd8k7zAtjd3ufgO8aTb uD4/6cYP/5eWrQ5WCiaOxmpf1H3UuwAB30FAr3xWDPkcgNuVDxXLWdBSMfKeBweU+q7pDpz7R4NFkhWt3rhFzPdRu6k5Uigan7XDTOcHEeHLHaMteSsaHbMD rh8Jzj52FqrHq3MXJ0Y4ey6IxqlGsiGHtdD0n5PQ9Jyn3IQPsPd8clUcMoqR0AHA Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2018 17:34:48 -0000 Thank you. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Mateusz Guzik Sent: 14/10/2018 10:14 To: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freeb= sd.org Subject: svn commit: r339355 - head/sys/cddl/contrib/opensolaris/uts/common= /fs/zfs Author: mjg Date: Sun Oct 14 16:14:01 2018 New Revision: 339355 URL: https://svnweb.freebsd.org/changeset/base/339355 Log: zfs: fix a panic after failed mount =20 r338927("zfs: depessimize zfs_root with rmlocks") failed to error check the mount before caching root vnode. =20 Results in crashes in rrw_enter_read_impl tracing back to zfs_mount. =20 Reported by: Mike Tancsa Tested by: allanjude Approved by: re (kib) Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c Sun Oc= t 14 05:09:43 2018 (r339354) +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c Sun Oc= t 14 16:14:01 2018 (r339355) @@ -1929,7 +1929,8 @@ zfs_mount(vfs_t *vfsp) error =3D zfs_domount(vfsp, osname); PICKUP_GIANT(); =20 - zfs_root_setvnode((zfsvfs_t *)vfsp->vfs_data); + if (error =3D=3D 0) + zfs_root_setvnode((zfsvfs_t *)vfsp->vfs_data); =20 #ifdef illumos /*