From owner-svn-src-all@FreeBSD.ORG  Wed Feb 11 22:17:26 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 429A01065765;
	Wed, 11 Feb 2009 22:17:26 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
	by mx1.freebsd.org (Postfix) with ESMTP id C56F58FC12;
	Wed, 11 Feb 2009 22:17:25 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (localhost [127.0.0.1])
	by alchemy.franken.de (8.14.3/8.14.3/ALCHEMY.FRANKEN.DE) with ESMTP id
	n1BMHKXh016428; Wed, 11 Feb 2009 23:17:20 +0100 (CET)
	(envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
	by alchemy.franken.de (8.14.3/8.14.3/Submit) id n1BMHK7G016427;
	Wed, 11 Feb 2009 23:17:20 +0100 (CET) (envelope-from marius)
Date: Wed, 11 Feb 2009 23:17:20 +0100
From: Marius Strobl <marius@alchemy.franken.de>
To: Coleman Kane <cokane@FreeBSD.org>
Message-ID: <20090211221720.GD93010@alchemy.franken.de>
References: <200902102154.n1ALsNCh005356@svn.freebsd.org>
	<1234303787.10699.4.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1234303787.10699.4.camel@localhost>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, "Zhang, Helen" <helen.zhang@bluecoat.com>
Subject: Re: svn commit: r188457 - head/sys/dev/bge
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2009 22:17:27 -0000

On Tue, Feb 10, 2009 at 05:09:47PM -0500, Coleman Kane wrote:
> On Tue, 2009-02-10 at 21:54 +0000, Marius Strobl wrote:
> > Author: marius
> > Date: Tue Feb 10 21:54:23 2009
> > New Revision: 188457
> > URL: http://svn.freebsd.org/changeset/base/188457
> > 
> > Log:
> >   Don't reset the PHY probe retry counter within the loop so
> >   it will eventually terminate as intended.
> >   
> >   Submitted by:	Helen Zhang
> > 
> > Modified:
> >   head/sys/dev/bge/if_bge.c
> > 
> > Modified: head/sys/dev/bge/if_bge.c
> > ==============================================================================
> > --- head/sys/dev/bge/if_bge.c	Tue Feb 10 21:51:33 2009	(r188456)
> > +++ head/sys/dev/bge/if_bge.c	Tue Feb 10 21:54:23 2009	(r188457)
> > @@ -2674,11 +2674,11 @@ bge_attach(device_t dev)
> >  		 * if we get a conflict with the ASF firmware accessing
> >  		 * the PHY.
> >  		 */
> > +		trys = 0;
> >  		BGE_CLRBIT(sc, BGE_MODE_CTL, BGE_MODECTL_STACKUP);
> >  again:
> >  		bge_asf_driver_up(sc);
> >  
> > -		trys = 0;
> >  		if (mii_phy_probe(dev, &sc->bge_miibus,
> >  		    bge_ifmedia_upd, bge_ifmedia_sts)) {
> >  			if (trys++ < 4) {
> > 
> 
> I'm curious... I recent ran into a problem where this driver was not
> properly recovering from an ACPI resume event (under amd64 with some
> patches). I am curious if this patch might fix that problem... as the
> death happened somewhere around here.

I doubt that.

> 
> What example case did you use to discover this bug?
> 

You'd need to ask Helen (CC'ed) regarding this.

Marius