From owner-p4-projects Fri Jul 19 12:19:15 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id F084B37B401; Fri, 19 Jul 2002 12:19:10 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92EDC37B400; Fri, 19 Jul 2002 12:19:10 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79E9443E5E; Fri, 19 Jul 2002 12:19:09 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.4/8.12.4) with SMTP id g6JJJ2Oo026242; Fri, 19 Jul 2002 15:19:03 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Fri, 19 Jul 2002 15:19:02 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "Brian F. Feldman" Cc: Perforce Change Reviews Subject: Re: PERFORCE change 14467 for review In-Reply-To: <200207191914.g6JJEkN15272@green.bikeshed.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 19 Jul 2002, Brian F. Feldman wrote: > Robert Watson wrote: > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14467 > > > > Change 14467 by rwatson@rwatson_paprika on 2002/07/19 08:13:14 > > > > New entry point 'mpo_create_extattr_from_vnode' to support > > the association of extended attribute backed MAC labels with a > > vnode on creation if the vnode is created on a generic > > EA-supporting file system with MAC/MULTILABEL enabled. This > > call provides access to the vnode, and if the entry point fails, > > then the creation operation will be aborted by the file system. > > > > TODO: mac_update_extattr_from_vnode() in a way that doesn't > > have race conditions and consistency problems. That's actually > > quite hard. > > Err... I don't like this name. It goes against the current convention > (which is de facto, I admit), so I think if we're running out of proper > ways to classify these operations into higher level sets we should > discuss extending the convention and renaming to support that. If you > want to start merging it into the main tree I think it would probably be > a good idea if we discussed the naming before that, you know? I don't > think this fits in any of the current sets of operations, just like > mac_externalize() et al :) Yeah, I agree, and had the same concerns, but figured we could rename it once we figured out what the other related calls would be called. I'm actually tempted to name these based on the fact that they have to do with the _std_foo_ea calls. I.e., make them be named mpo_stdcreate_ea(), mpo_stdupdate_ea(), etc. Thoughts? Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message