From owner-freebsd-current@FreeBSD.ORG  Mon Nov 17 18:07:54 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9BD8F1065670;
	Mon, 17 Nov 2008 18:07:54 +0000 (UTC) (envelope-from dfr@rabson.org)
Received: from itchy.rabson.org (unknown [IPv6:2002:50b1:e8f2:1::143])
	by mx1.freebsd.org (Postfix) with ESMTP id 5342B8FC08;
	Mon, 17 Nov 2008 18:07:54 +0000 (UTC) (envelope-from dfr@rabson.org)
Received: from [IPv6:2001:470:909f:1:21b:63ff:feb8:5abc] (unknown
	[IPv6:2001:470:909f:1:21b:63ff:feb8:5abc])
	by itchy.rabson.org (Postfix) with ESMTP id CFF0D3FB7;
	Mon, 17 Nov 2008 18:06:39 +0000 (GMT)
Message-Id: <8A43CF07-D06F-4EAF-A171-DF7F10F036F5@rabson.org>
From: Doug Rabson <dfr@rabson.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
In-Reply-To: <20081117180253.GA1733@garage.freebsd.pl>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v929.2)
Date: Mon, 17 Nov 2008 18:07:52 +0000
References: <20081117171017.GB1489@garage.freebsd.pl>
	<4AC8E131-CD12-4075-948F-DA187B4EE2AD@rabson.org>
	<20081117180253.GA1733@garage.freebsd.pl>
X-Mailer: Apple Mail (2.929.2)
X-Virus-Scanned: ClamAV 0.92/8642/Mon Nov 17 04:01:08 2008 on itchy.rabson.org
X-Virus-Status: Clean
Cc: freebsd-current@FreeBSD.org
Subject: Re: NFS regression.
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Nov 2008 18:07:54 -0000


On 17 Nov 2008, at 18:02, Pawel Jakub Dawidek wrote:

> On Mon, Nov 17, 2008 at 05:54:02PM +0000, Doug Rabson wrote:
>>
>> On 17 Nov 2008, at 17:10, Pawel Jakub Dawidek wrote:
>>
>>> Hi.
>>>
>>> I'm seeing this panic very often now with few days old HEAD:
>>>
>>>
>>> Any ideas?
>>
>> Can you reproduce this with INVARIANTS turned on? That should trigger
>> a KASSERT a bit earlier and give me a chance to fix the thing.
>
> I've INVARIANTS on... Is there some assertion added recently you are
> expecting?

Hmm. I added an assert in r184921 which ought to have caught this.  
Could you try this patch and see if it changes anything:

Index: rpc/clnt_dg.c
===================================================================
--- rpc/clnt_dg.c	(revision 184968)
+++ rpc/clnt_dg.c	(working copy)
@@ -543,7 +543,7 @@

  		if (tv > 0) {
  			if (cu->cu_closing || cu->cu_closed)
-				error = 0;
+				error = ESHUTDOWN;
  			else
  				error = msleep(cr, &cs->cs_lock,
  				    cu->cu_waitflag, cu->cu_waitchan, tv);