Date: Wed, 22 May 2002 17:58:28 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Jake Burkholder <jake@locore.ca> Cc: "David O'Brien" <obrien@FreeBSD.org>, Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/elf2aout elf2aout.c Message-ID: <20020522145828.GB55670@sunbay.com> In-Reply-To: <20020522104552.F62759@locore.ca> References: <20020520144919.D62759@locore.ca> <20020522211222.X9440-100000@gamplex.bde.org> <20020522104552.F62759@locore.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--DBIVS5p969aUjpLe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, May 22, 2002 at 10:45:52AM -0400, Jake Burkholder wrote:
> Apparently, On Wed, May 22, 2002 at 09:38:53PM +1000,
> Bruce Evans said words to the effect of;
>=20
> > On Mon, 20 May 2002, Jake Burkholder wrote:
> >=20
> > > Apparently, On Mon, May 20, 2002 at 08:24:31PM +0300,
> > > Ruslan Ermilov said words to the effect of;
> > >
> > > > On Mon, May 20, 2002 at 07:17:39PM +0300, Ruslan Ermilov wrote:
> > > > > On Mon, May 20, 2002 at 12:15:14PM -0400, Jake Burkholder wrote:
> > > > > > Apparently, On Mon, May 20, 2002 at 12:56:40AM -0700,
> > > > > > Ruslan Ermilov said words to the effect of;
> > > > > >
> > > > > > > ru 2002/05/20 00:56:40 PDT
> > > > > > >
> > > > > > > Modified files:
> > > > > > > usr.bin/elf2aout elf2aout.c
> > > > > > > Log:
> > > > > > > s/u_int/u_int32_t/
> > > > > >
> > > > > > I would have preferred you to not commit this, it does nothing.
> > > > > >
> > > > > It makes code more MI, as u_int is not guaranteed to be 32 bit.
> > > > > This also makes it explicit that we're dealing with the elf32
> > > > > here, not elf64.
> > > > >
> > > > These would even better be declared using the Elf32_* types.
> > > > Could you please fix this?
> > >
> > > Umm, its an a.out header. u_int{,32_t} is correct.
> >=20
> > Actually, a fixed-width unsigned integer type with the same number of
> > bits as `unsigned long' on the target machine is correct, since the
> > type in a target struct exec is `unsigned long' (see <sys/imgact.h>).
> > `unsigned long' for all targets is inconvenient for cross-compiling
> > and gratuitously compiler-dependent, but it was almost as good as
> > possible since it was the largest integer type. `u_int' for all targets
> > would be just broken since it might be 16 bits.
>=20
> The target machine is actually sparcv8.
>=20
Only at the moment, and what's wrong if this tool will support any
supportable target?
On Thu, May 16, 2002 at 12:08:16PM -0700, David O'Brien wrote:
[...]
> elf2aout will also be needed on ARM and maybe PowerPC.
Cheers,
--=20
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
--DBIVS5p969aUjpLe
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)
iD8DBQE867IUUkv4P6juNwoRAmKpAJ9NZ6B9X9guBQAMRHgksa32bwS4TgCfeRXo
jOl/Jmupd/dFBnoJcC11DR0=
=daJS
-----END PGP SIGNATURE-----
--DBIVS5p969aUjpLe--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020522145828.GB55670>